lib/cpp-httplib
1
0
Fork 0
mirror of synced 2025-12-18 16:34:09 +03:00
Code Activity

Resolved code review comments

Browse Source
This commit is contained in:
yhirose
2025-12-05 00:32:30 -05:00
parent 593199caa4
commit 82e892db2d
1 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
test/test.cc
View File

@@ -12697,6 +12697,7 @@ TEST(ETagTest, StaticFileETagAndIfNoneMatch) {
{ {
std::ofstream ofs(fname); std::ofstream ofs(fname);
ofs << content; ofs << content;
ASSERT_TRUE(ofs.good());
} }
Server svr; Server svr;
@@ -12719,6 +12720,7 @@ TEST(ETagTest, StaticFileETagAndIfNoneMatch) {
EXPECT_EQ('W', etag[0]); EXPECT_EQ('W', etag[0]);
EXPECT_EQ('/', etag[1]); EXPECT_EQ('/', etag[1]);
EXPECT_EQ('"', etag[2]); EXPECT_EQ('"', etag[2]);
EXPECT_EQ('"', etag.back());
// Exact match: expect 304 Not Modified // Exact match: expect 304 Not Modified
Headers h2 = {{"If-None-Match", etag}}; Headers h2 = {{"If-None-Match", etag}};
@@ -12758,6 +12760,7 @@ TEST(ETagTest, LastModifiedAndIfModifiedSince) {
{ {
std::ofstream ofs(fname); std::ofstream ofs(fname);
ofs << content; ofs << content;
ASSERT_TRUE(ofs.good());
} }
Server svr; Server svr;
@@ -12859,6 +12862,7 @@ TEST(ETagTest, IfRangeWithETag) {
{ {
std::ofstream ofs(fname); std::ofstream ofs(fname);
ofs << content; ofs << content;
ASSERT_TRUE(ofs.good());
} }
Server svr; Server svr;
@@ -12919,6 +12923,7 @@ TEST(ETagTest, IfRangeWithDate) {
{ {
std::ofstream ofs(fname); std::ofstream ofs(fname);
ofs << content; ofs << content;
ASSERT_TRUE(ofs.good());
} }
Server svr; Server svr;