From 82e892db2de256e97a683968e1508934e12c24ab Mon Sep 17 00:00:00 2001 From: yhirose Date: Fri, 5 Dec 2025 00:32:30 -0500 Subject: [PATCH] Resolved code review comments --- test/test.cc | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/test/test.cc b/test/test.cc index d93a27b..dd78cbc 100644 --- a/test/test.cc +++ b/test/test.cc @@ -12697,6 +12697,7 @@ TEST(ETagTest, StaticFileETagAndIfNoneMatch) { { std::ofstream ofs(fname); ofs << content; + ASSERT_TRUE(ofs.good()); } Server svr; @@ -12719,6 +12720,7 @@ TEST(ETagTest, StaticFileETagAndIfNoneMatch) { EXPECT_EQ('W', etag[0]); EXPECT_EQ('/', etag[1]); EXPECT_EQ('"', etag[2]); + EXPECT_EQ('"', etag.back()); // Exact match: expect 304 Not Modified Headers h2 = {{"If-None-Match", etag}}; @@ -12758,6 +12760,7 @@ TEST(ETagTest, LastModifiedAndIfModifiedSince) { { std::ofstream ofs(fname); ofs << content; + ASSERT_TRUE(ofs.good()); } Server svr; @@ -12859,6 +12862,7 @@ TEST(ETagTest, IfRangeWithETag) { { std::ofstream ofs(fname); ofs << content; + ASSERT_TRUE(ofs.good()); } Server svr; @@ -12919,6 +12923,7 @@ TEST(ETagTest, IfRangeWithDate) { { std::ofstream ofs(fname); ofs << content; + ASSERT_TRUE(ofs.good()); } Server svr;