mirror of
https://git.savannah.gnu.org/git/coreutils.git
synced 2026-11-17 18:02:09 +03:00
Exempt init.sh because it runs before we're assured to have a
shell that groks $(...). Exempt *.mk because "$" would have to
be doubled, and besides, any `...` expression in a .mk file is
almost certainly evaluated before init.sh is run. Finally, also
exempt the perl-based tests, because perl's `...` cannot be
converted to $(...). Do that by running this command:
git grep -l '`.*`' tests \
| grep -Ev 'init\.sh|\.mk$' | xargs grep -Lw perl \
| xargs perl -pi -e 's/`(.*?)`/\$($1)/g'
One minor fix-up change was required after that, due to how
quoting differs:
diff --git a/tests/chmod/equals b/tests/chmod/equals
- expected_perms=$(eval 'echo \$expected_'$dest)
+ expected_perms=$(eval 'echo $expected_'$dest)
Another was to make these required quoting adjustments:
diff --git a/tests/misc/stty b/tests/misc/stty
...
- rev=$(eval echo "\\\$REV_$opt")
+ rev=$(eval echo "\$REV_$opt")
...
- rev1=$(eval echo "\\\$REV_$opt1")
- rev2=$(eval echo "\\\$REV_$opt2")
+ rev1=$(eval echo "\$REV_$opt1")
+ rev2=$(eval echo "\$REV_$opt2")
Also, transform two files that were needlessly excluded above:
(both use perl, but are mostly bourne shell)
perl -pi -e 's/`(.*?)`/\$($1)/g' \
tests/du/long-from-unreadable tests/init.cfg
60 lines
2.0 KiB
Bash
Executable File
60 lines
2.0 KiB
Bash
Executable File
#!/bin/sh
|
|
# make sure chown --from=... works
|
|
|
|
# Copyright (C) 2001-2012 Free Software Foundation, Inc.
|
|
|
|
# This program is free software: you can redistribute it and/or modify
|
|
# it under the terms of the GNU General Public License as published by
|
|
# the Free Software Foundation, either version 3 of the License, or
|
|
# (at your option) any later version.
|
|
|
|
# This program is distributed in the hope that it will be useful,
|
|
# but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
# GNU General Public License for more details.
|
|
|
|
# You should have received a copy of the GNU General Public License
|
|
# along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
|
|
. "${srcdir=.}/init.sh"; path_prepend_ ../src
|
|
print_ver_ chgrp
|
|
require_root_
|
|
|
|
touch f || framework_failure_
|
|
|
|
chown -R --preserve-root 0:1 f
|
|
|
|
# Make sure the owner and group are 0 and 1 respectively.
|
|
set _ $(ls -n f); shift; test "$3:$4" = 0:1 || fail=1
|
|
|
|
# Make sure the correct diagnostic is output
|
|
# Note we output a name even though an id was specified.
|
|
chown -v --from=42 43 f > out || fail=1
|
|
printf "ownership of 'f' retained as $(id -nu)\n" > exp
|
|
compare exp out || fail=1
|
|
|
|
# Ensure diagnostics work for non existent files.
|
|
chown -v 0 nf > out && fail=1
|
|
printf "failed to change ownership of 'nf' to 0\n" > exp
|
|
compare exp out || fail=1
|
|
|
|
chown --from=0:1 2:010 f || fail=1
|
|
|
|
# And now they should be 2 and 10 respectively.
|
|
set _ $(ls -n f); shift; test "$3:$4" = 2:10 || fail=1
|
|
|
|
ln -s f slink
|
|
# Applying chown to a symlink with --no-dereference
|
|
# should change only the link.
|
|
chown --no-dereference 0:1 slink || fail=1
|
|
# owner/group on the symlink should be set
|
|
set _ $(ls -n slink); shift; test "$3:$4" = 0:1 || fail=1
|
|
# owner/group on the referent should remain unchanged
|
|
set _ $(ls -n f); shift; test "$3:$4" = 2:10 || fail=1
|
|
|
|
chown --no-dereference --from=0:1 2:010 slink || fail=1
|
|
# owner/group on the symlink should be changed
|
|
set _ $(ls -n slink); shift; test "$3:$4" = 2:10 || fail=1
|
|
|
|
Exit $fail
|