Commit Graph
3937 Commits
Author SHA1 Message Date
Jim Meyering 4d863fd68b (strtoull): Remove unused declaration. 2003-08-17 17:48:14 +00:00
Jim Meyering f976fd6f38 Avoid unnecessary and sometimes time-consuming hostname lookups.
(print_user): Likewise.

This fixes a typo I introduced in who-users.c on 1996-02-23.
2003-08-17 16:04:00 +00:00
Jim Meyering 7cea884787 Avoid unnecessary and sometimes time-consuming hostname lookups.
(print_entry): Likewise.

This fixes a typo I introduced in who-users.c on 1996-02-23.
2003-08-17 16:03:42 +00:00
Jim Meyering 1ead947b79 . 2003-08-17 07:49:10 +00:00
Jim Meyering f6008be14a (tail_lines): Fix a potential (but very hard to exercise)
race condition bug.  The bug would be triggered when tailing a file
with file pointer not at beginning of file, and where the file was
truncated to have a length of less than the initial offset at just
the right moment (between the two lseek calls in this function).
2003-08-16 17:34:41 +00:00
Jim Meyering f4be51104a An invalid initial value for *read_pos would result in
`tail -n0 -f FILE' and `tail -c0 -f FILE' doing what amounted to a
busy-wait rather than sleeping between iterations.  The bug manifests
itself only when tailing regular files that are initially nonempty.

(tail_bytes): Set *read_pos to new file offset after
each xlseek call.
(tail_lines): Likewise, after lseek calls.
2003-08-16 17:28:33 +00:00
Jim Meyering dcdee393d7 . 2003-08-15 06:54:15 +00:00
Jim Meyering 4f6b3338a1 (ASSORT): New var.
(check-README, ../AUTHORS): Use it.
2003-08-15 06:53:02 +00:00
Jim Meyering 11d239448d . 2003-08-15 06:43:29 +00:00
Jim Meyering 31f092ff08 . 2003-08-11 18:25:04 +00:00
Jim Meyering d761e22b60 fold -s -wN would infloop for N < 8 with TABs in the input.
E.g., this would not terminate: printf 'a\tb' | fold -w2 -s

(fold_file): Move contents of `else'-block
out of conditional so it's used also for --spaces (-s).
2003-08-11 14:35:52 +00:00
Jim Meyering cc664579f8 [!NICE_PRIORITY]: Include <sys/resource.h> after
system.h so the types from time.h and sys/time.h are available.
It appears that this is necessary for OpenBSD, NetBSD, and
Darwin 6.5 (MacOS 10.2.5).  Reported by Nelson Beebe.
2003-08-10 17:50:11 +00:00
Jim Meyering 9b1bd49df2 Include utimens.h.
Set file timestamps with utimens, not utime.
2003-08-09 18:35:07 +00:00
Jim Meyering 9b51a5db83 Include utimens.h.
(copy_internal): Set file timestamps with utimens, not utime.
2003-08-09 17:48:41 +00:00
Jim Meyering c9df366ee5 Include utimens.h.
(change_timestamps): Set file timestamps with utimens, not utime.
2003-08-09 17:47:34 +00:00
Jim Meyering 40802a2fbd Include utimens.h.
(re_protect): Set file timestamps with utimens, not utime.
2003-08-09 17:46:13 +00:00
Jim Meyering 4352921096 (main): Tweak Solaris OS version number in comment. 2003-08-09 16:34:32 +00:00
Jim Meyering dc14125393 Tweak Solaris OS version number in comment. 2003-08-09 16:34:22 +00:00
Jim Meyering fd54759957 (pipe_lines): Use memchr to skip lines, rather than an explicit loop. 2003-08-09 15:32:42 +00:00
Jim Meyering 5422ec14ea Add new undocumented option, --presume-input-pipe. 2003-08-09 15:31:13 +00:00
Jim Meyering 2376c2480d . 2003-08-09 14:11:42 +00:00
Jim Meyering 27c678fc89 (suffix_alphabet): New var.
(longopts, usage, next_file_name, main): Support -d.
(next_file_name, main): Allow -a0, as POSIX requires.
(next_file_name): Don't assume ASCII-like encoding;
'a' through 'z' are not contiguous in EBCDIC.
2003-08-09 09:16:39 +00:00
Jim Meyering 54288039b7 . 2003-08-07 09:41:34 +00:00
Jim Meyering 00f84b1e64 Include getndelim2.h rather than getdelim2.h.
(cut_fields): Invoke getndelim2 rather than getdelim2.
2003-08-07 09:33:48 +00:00
Jim Meyering 5dfc40658f . 2003-08-07 08:03:12 +00:00
Jim Meyering 5a6401d82e . 2003-08-06 19:36:32 +00:00
Jim Meyering cf572dd1d0 (main): Use unsigned int instead of int for `nsigs'
and for the indices to iterate through nsigs.
2003-08-04 08:55:44 +00:00
Jim Meyering 801362fc36 Minor code cleanups, mostly to use more accurate
types and to remove unnecessary casts.
(min, max): Remove.  All uses changed to MIN and MAX.
(hard_lc_collate, hard_LC_TIME, struct buffer.eof, struct
keyfield.skipsblanks, struct keyfield.skipeblanks, struct
keyfield.numeric, struct keyfield.general_numeric, struct
keyfield.month, struct keyfield.reverse, reverse, unique,
have_read_stdin): Now bool, not int.  All uses changed.
(eolchar): Now char, not int.
(struct keyfield.ignore): Now bool const *, not int *.
(struct keyfield.translate): Now char const *, not char *.
(struct month.name): Likewise.
(blanks, nonprinting, nondictionary): Now bool[], not int[].
(cleanup, inittables, keycompare, check, mergefps, first_same_file,
check, sort, main): Use const * pointers when possible.
(month_cmp): Rewrite to avoid casts.
(inittables): Initialize tables unconditionally, to avoid branches.
(fillbuf): Return bool, not int.  All uses changed.
(fillbuf, keycompare, new_key, main):
Use SIZE_MAX rather than (size_t) -1.
(trailing_blanks): Renamed from trim_trailing_blanks.
Return the number of blanks to trim.  All uses changed.
(getmonth): Use trailing_blanks rather than open code.
(keycompare): Do not cast char * to unsigned char *; not needed.
CMP_WITH_IGNORE converts args to UCHAR, so no need to convert it
ourselves.
(compare, main): Use | rather than || to avoid jumps.
Replace "diff = NONZERO (alen)" with "diff = 1", since alen must
be nonzero there.
(check, first_same_file, sort, main):
Use bool instead of int local vars when possible.
(check): Merge the old 'checkfp' and 'check' into a single function,
that returns a boolean (true if the file was ordered).
All uses changed.
(main): Use int instead of unsigned for iterating through nsigs.
Rename local var "posix_pedantic" to "posixly_correct".
2003-08-03 10:28:10 +00:00
Jim Meyering 846a7a53eb [!NICE_PRIORITY]: Include <time.h> before <sys/resource.h>
to avoid compilation error on Ultrix. Reported by Christian Krackowizer.
2003-08-02 20:39:06 +00:00
Jim Meyering aca28ca9ac (cut_fields): Don't read again after encountering EOF.
E.g., `cut -f2' would do so.
2003-08-02 19:53:52 +00:00
Jim Meyering 054819d791 (sortlines): Add description and references.
From Paul Eggert.
2003-08-02 06:25:50 +00:00
Jim Meyering 953ab84d68 (long_options, usage, main): Add --rfc-2822 option to GNU date. 2003-08-01 22:36:34 +00:00
Jim Meyering 09df41c60f Do not include bumpalloc.h.
(WORD_TABLE): New member alloc.
(ALLOC_NEW_WORD): Remove.
(occurs_alloc): New var.
(digest_word_file, find_occurs_in_text): Check for arithmetic
overflow when computing table size.  Use xrealloc rather than
bumpalloc primitives.
2003-08-01 06:44:28 +00:00
Jim Meyering 689ba6d996 . 2003-07-31 11:14:56 +00:00
Jim Meyering 32d9cf7b5b (sortlines_temp): Undo previous change. 2003-07-28 08:31:11 +00:00
Jim Meyering 682d905a29 (sortlines_temp): Declare local swap' to be int', not
`bool'.  Otherwise, at least one buggy compiler (alpha gcc-2.95.4)
would cause lines[-1 - swap] (with swap = false) to evaluate to
lines[4294967295].
2003-07-27 22:05:43 +00:00
Jim Meyering c50b21161b (prompt) [! recursive]: Don't prompt about unwritable
directories, as required by POSIX.   Reported by Karl Berry.
2003-07-27 19:47:25 +00:00
Jim Meyering 379405a3a3 remove trailing blanks 2003-07-27 08:58:55 +00:00
Jim Meyering 6013cbabde (sort): Don't require two `struct line's per text line,
the new sort algorithm requires just 1.5.
2003-07-27 08:28:13 +00:00
Jim Meyering 665f7a2d0f This change was inspired by a similar proposal by Stepan Kasal.
(mergelines, sortlines_temp): New functions.
(sortlines): Use them, to reduce the number of times that
we need to copy 'struct line' values.  This improved CPU
performance by about 30% on one 18 MB test.
(sort): Don't invoke sortlines unless we have 2 or more lines.
2003-07-27 08:26:49 +00:00
Jim Meyering 9ee5095608 (is_printable_field): Simplify bit arithmetic. 2003-07-27 06:45:56 +00:00
Jim Meyering 036e172a16 (validate_path): Use %lu, not %ld. 2003-07-27 06:45:25 +00:00
Jim Meyering b595cc6f24 (sort_files): Put `volatile' in the right place. 2003-07-27 06:34:52 +00:00
Jim Meyering e206ab7b6f . 2003-07-26 14:54:50 +00:00
Jim Meyering 9fed987cf2 Include exitfail.h.
(TEST_FAILURE): New constant, used for exit status if 'test' fails.
(test-syntax_error): Use it.
(binary_operator): Now takes bool arg specifying whether left operand
is -l ARG, so that caller determines this rather than us.
All uses changed.
(term): Use posixtest to evaluate parenthesized subexpressions.
(unary_operator, one_argument): Remove support for -t without operand.
(one_argument): Take argument from argv[pos].
(one_argument, two_arguments, three_arguments): Advance pos.
All callers changed.
(three_arguments): Look for binary ops before "!".  Then look
for parenthesized one_argument expressions, instead of trusting
expr () to do the right thing.
(posixtest): Now takes number of args.  All callers changed.
Treat "( A B )" like "A B".
(main): Set exit_failure to TEST_FAILURE.  Don't depend on
POSIXLY_CORRECT, as we now conform to POSIX by default.
(main) [!LBRACKET]: Do not recognize "--help" or "--verbose" unless.
2003-07-26 12:22:42 +00:00
Jim Meyering df1bfa25aa Use only one bit per field/offset in array, not one `int'.
(printable_field): Change type to `unsigned char'.
(mark_printable_field, is_printable_field): New functions.
Use them in place of all direct accesses of `printable_field'.
2003-07-26 09:40:14 +00:00
Jim Meyering 421680e11c (set_fields): Detect overflow properly. 2003-07-26 09:12:30 +00:00
Jim Meyering cab4bde6e1 (parse_tabstops): Detect overflow properly. 2003-07-26 09:10:45 +00:00
Jim Meyering 46baf9f422 * src/rm.c: Include "dirname.h".
(usage): Use base_name (program_name) in body of --help output.
	This lets me...
	* man/Makefile.am (.x.1): ...back out the kludge of 2003-07-22.
2003-07-26 09:02:54 +00:00
Jim Meyering 0c006268e6 (AM_INSTALLCHECK_STD_OPTIONS_EXEMPT): Exempt test. 2003-07-26 07:28:43 +00:00