mirror of
https://git.savannah.gnu.org/git/coreutils.git
synced 2026-11-17 18:02:09 +03:00
(tail_lines): Fix a potential (but very hard to exercise)
race condition bug. The bug would be triggered when tailing a file with file pointer not at beginning of file, and where the file was truncated to have a length of less than the initial offset at just the right moment (between the two lseek calls in this function).
This commit is contained in:
1 parent
f4be51104a
commit
f6008be14a
1 file changed
+8
-1
+8
-1
@@ -1184,7 +1184,7 @@ tail_lines (const char *pretty_filename, int fd, uintmax_t n_lines,
|
||||
}
|
||||
else
|
||||
{
|
||||
off_t start_pos;
|
||||
off_t start_pos = -1;
|
||||
off_t end_pos;
|
||||
|
||||
/* Use file_lines only if FD refers to a regular file for
|
||||
@@ -1201,6 +1201,13 @@ tail_lines (const char *pretty_filename, int fd, uintmax_t n_lines,
|
||||
}
|
||||
else
|
||||
{
|
||||
/* Under very unlikely circumstances, it is possible to reach
|
||||
this point after positioning the file pointer to end of file
|
||||
via the `lseek (...SEEK_END)' above. In that case, reposition
|
||||
the file pointer back to start_pos before calling pipe_lines. */
|
||||
if (start_pos != -1)
|
||||
xlseek (fd, start_pos, SEEK_SET, pretty_filename);
|
||||
|
||||
return pipe_lines (pretty_filename, fd, n_lines, read_pos);
|
||||
}
|
||||
}
|
||||
|
||||
Reference in new issue
Block a user