Commit Graph
18365 Commits
Author SHA1 Message Date
Jim Meyering 83db4e147a When chown or chgrp is modifying the referent of a symlink,
use the chown(2) function, if possible.

(change_file_owner): Don't hard-code the
open/fchown/close kludge here.  Use `chown' instead.
The chown function works just fine on conforming systems.
Other systems now go through the new chown wrapper that
resorts to the old kludge.
2004-05-01 14:33:41 +00:00
Jim Meyering afef52af2f *** empty log message *** 2004-05-01 06:49:01 +00:00
Jim Meyering 27b510575d (change_file_owner): Add a comment. 2004-05-01 06:48:55 +00:00
Jim Meyering 70b9c50903 . 2004-04-29 16:03:21 +00:00
Jim Meyering 094bc55f63 Whoops: s/sc_src_tight_scope/sc_tight_scope/ 2004-04-28 12:42:14 +00:00
Jim Meyering 173f088735 . 2004-04-27 19:01:00 +00:00
Jim Meyering 372762d891 (syntax_table, re_syntax_table): Remove declarations of two unused
variables (they were exposed by the above change).
2004-04-27 18:39:21 +00:00
Jim Meyering 335b993492 Make over 40 global extern variables `static'. 2004-04-27 18:37:14 +00:00
Jim Meyering ee5d9d5b14 (sc_tight_scope): Also check for global variables, (BSS section). 2004-04-27 17:03:58 +00:00
Jim Meyering 74a28492df *** empty log message *** 2004-04-27 16:58:16 +00:00
Jim Meyering 6a9fd0063c Rename to sc_tight_scope.
(syntax-check-rules): Really add it.
2004-04-27 16:58:02 +00:00
Jim Meyering 3353acdf8f Rename to sc_tight_scope. 2004-04-27 16:57:23 +00:00
Jim Meyering f945a484b6 *** empty log message *** 2004-04-27 16:36:08 +00:00
Jim Meyering 72e9f1ce4b (backup_type): Declare `static'. 2004-04-27 16:36:03 +00:00
Jim Meyering ec38270d8e (opt_nul_terminate_output): Declare `static'. 2004-04-27 16:34:47 +00:00
Jim Meyering b480c61d5e (G_fail): Declare `static'. 2004-04-27 16:32:43 +00:00
Jim Meyering 4c59a5f180 *** empty log message *** 2004-04-27 15:02:35 +00:00
Jim Meyering a84b7ad221 (forget_created, remember_created)
(src_to_dest_lookup, remember_copied, hash_init, forget_all):
Add `extern' keyword.
2004-04-27 15:02:11 +00:00
Jim Meyering 68c7c2d2fa (dest_info_init, src_info_init, copy): Add `extern' keyword. 2004-04-27 15:01:31 +00:00
Jim Meyering 03f9a376a4 (chopt_init, chopt_free, gid_to_name, uid_to_name, chown_files):
Add `extern' keyword.
2004-04-27 15:01:12 +00:00
Jim Meyering b34611fd0f (rm): Add `extern' keyword. 2004-04-27 15:00:32 +00:00
Jim Meyering 37989d195a . 2004-04-27 14:57:48 +00:00
Jim Meyering 36968546e5 (sc_src_functions_have_static_scope): New rule. 2004-04-27 14:57:33 +00:00
Jim Meyering e014b02b5f *** empty log message *** 2004-04-27 14:57:17 +00:00
Jim Meyering 350228c3be (sc_src_functions_have_static_scope): New rule.
(syntax-check-rules): Add it.
2004-04-27 14:57:11 +00:00
Jim Meyering c09c476689 *** empty log message *** 2004-04-26 16:31:42 +00:00
Jim Meyering 53080d0a85 . 2004-04-26 16:31:14 +00:00
Jim Meyering b07f9bf8b6 *** empty log message *** 2004-04-26 15:45:53 +00:00
Jim Meyering b88eb38b98 Fix typo in env_default comment.
(18c, 18d): Reverse the order of output lines, so that the
test cases conform to POSIX.
2004-04-26 15:43:37 +00:00
Jim Meyering 9a3fee94a0 Fix typo in env_default comment. 2004-04-26 15:39:02 +00:00
Jim Meyering 79f8908c8a *** empty log message *** 2004-04-26 15:38:16 +00:00
Jim Meyering c20e6668c8 (sort invocation): Mention -k earlier, so
that the options are in alphabetical order.  Describe how -b works
more-accurately; this involves fixing some examples, too.  Mention
what happens if the start field falls after an end field or after
a line end.  Warn about using -k without -b, -g, -M, -n, or -t.
Add an example of how to sort IPv4 addresses and Apache Common
Log Format dates.  Remove a duplicate example.
(Putting the tools together): Use separate options rather
than agglomerating them.
2004-04-26 15:37:48 +00:00
Jim Meyering 30ea278e1b (limfield): Make a comment clearer. 2004-04-26 15:37:33 +00:00
Jim Meyering 41cc9a718a Fix POSIX-conformance bug: "sort -k 3,3.5b" is supposed to skip
leading blanks when computing the location of the field end;
it is not supposed to skip trailing blanks.  Solaris 8 "sort"
does conform to POSIX.  Also fix the documentation to clarify
this and related issues.

(limfield): Use skipeblanks, not skipsblanks, to
decode whether to skip leading blanks.
(trailing_blanks): Remove.
(fillbuf, getmonth, keycompare): Don't trim trailing blanks.
2004-04-26 15:31:13 +00:00
Jim Meyering 431d661863 update from master 2004-04-26 13:59:35 +00:00
Jim Meyering 48d44f4301 . 2004-04-24 08:09:52 +00:00
Jim Meyering 5536fd32b1 . 2004-04-24 08:08:06 +00:00
Jim Meyering 9ba449c94b *** empty log message *** 2004-04-24 08:04:20 +00:00
Jim Meyering 58e4afaacf (gl_MACROS): Check for tcgetpgrp. 2004-04-24 08:03:46 +00:00
Jim Meyering adc30a8396 More signal-handling cleanup for ls.c. Do not allow signals to
happen between arbitrary output bytes, as the
restore-default-color sequence can bollix up multibyte chars or
color-change sequences in the ordinary output.  Instead, process
signals only between printing a file name and changing the color
back to non_filename_text color.  That way, if the signal handler
changes the color (to the default), 'ls' will change it back when
'ls' continues (after being suspended).

Also, do not bother with signal-handling unless stdout is a
controlling terminal; this lets stdio buffer better when "ls
--color" is piped or sent to a file.

(sigprocmask, sigset_t) [!defined SA_NOCLDSTOP]: New macros.
Do not include "full-write.h"; no longer needed.
(tcgetpgrp) [! HAVE_TCGETPGRP]: New macro.
(put_indicator_direct): Remove.  All callers changed to use
put_indicator.
(caught_signals, interrupt_signal, stop_signal_count): New vars.
(restore_default_color): Don't bother checking for put_indicator
failure.
(sighandler): Don't handle SIGTSTP; that's another handler now.
Simply set interrupt_signal to the signal, then exit.
(stophandler, process_signals): New functions.
(main): Don't output any color changes until _after_ the signal
handlers are set up.  This fixes a race condition where 'ls'
could be interrupted while initializing colors, and leaving the
terminal in an undesirable state.
Don't mess with signal-handling if standard output is not a
controlling terminal.
When exiting, restore the default color, then restore the
default signal handling, then act on any signals that weren't
acted on yet.
Do not print //DIRED// etc. in colors; this avoids the need
to catch signals when printing them.
(print_name_with_quoting): Process signals just before switching
color back to non_filename_text.
2004-04-24 08:03:15 +00:00
Jim Meyering 8d90a31290 *** empty log message *** 2004-04-23 17:32:32 +00:00
Jim Meyering e356a9a6ea Avoid segfault on systems for which SIZE_MAX != (size_t) -1.
(quote_name): Use SIZE_MAX, not -1, in calls of quotearg_buffer.
Patch by Mikulas Patocka.
2004-04-23 17:32:25 +00:00
Jim Meyering 656883d775 *** empty log message *** 2004-04-23 17:27:20 +00:00
Jim Meyering d6079f7509 *** empty log message *** 2004-04-23 06:42:34 +00:00
Jim Meyering 096ac55884 Don't check for values.h; it's no longer used. 2004-04-23 06:42:31 +00:00
Jim Meyering 6a1ee7ca70 *** empty log message *** 2004-04-21 14:26:45 +00:00
Jim Meyering 57c7fbf44a *** empty log message *** 2004-04-21 14:26:17 +00:00
Jim Meyering ed4778772c (main): Do not ignore SIGPIPE, as POSIX 1003.1-2001
does not allow this.  This undoes the 1996-10-24 patch.
2004-04-21 14:26:09 +00:00
Jim Meyering b55c0ce8ee *** empty log message *** 2004-04-21 12:57:46 +00:00
Jim Meyering 8ab60c41be - csplit sometimes failed to remove files when interrupted.
- csplit didn't clean up if two signals arrived nearly simultaneously.

(sigprocmask, sigset_t) [!defined SA_NOCLDSTOP]: Define.
(filename_space, prefix, suffix, digits, files_created, remove_files): Now volatile.
(caught_signals): New var.
(cleanup): Block signals while deleting all files.
(cleanup_fatal, handle_line_error, regexp_error):
Mark with ATTRIBUTE_NORETURN.
(create_output_file, close_output_file, interrupt_handler):
Block signals while changing the number of output files,
to fix some race conditions.
(delete_all_files): Do nothing if remove_files is zero.
Clear files_created.
(main): Don't mess with signals until after argument processing is done.

(main): Rewrite signal-catching code to make it
similar to other coreutils programs.  When processing signals,
block all signals that we catch, but do not block signals that we
don't catch.  Avoid problems with unsigned int warnings.

(interrupt_handler): Use void, not (obsolete) RETSIGTYPE.

(interrupt_handler) [defined SA_NOCLDSTOP]:
Use simpler "signal (sig, SIG_DFL)" rather than sigaction equivalent.
2004-04-21 12:57:33 +00:00