build: prohibit improper use of stat and lstat

* cfg.mk (sc_prohibit_stat_macro_address): New rule.
* src/ln.c (do_link): Adjust comment to avoid false positive.
* src/stat.c (do_stat): Likewise.
* src/touch.c (main): Likewise.
This commit is contained in:
Eric Blake committed 2009-10-23 06:29:54 -06:00
1 parent a08e13a0fb
commit c0dcf3238b
4 files changed
+9 -3

No files matched your search

+6
View File
@@ -197,6 +197,12 @@ sc_prohibit_readlink:
msg='do not use readlink(at); use via xreadlink or areadlink*' \
$(_prohibit_regexp)
# Don't use address of "stat" or "lstat" functions
sc_prohibit_stat_macro_address:
@re='\<l?stat '':|&l?stat\>' \
msg='stat() and lstat() may be function-like macros' \
$(_prohibit_regexp)
# Ensure that date's --help output stays in sync with the info
# documentation for GNU strftime. The only exception is %N,
# which date accepts but GNU strftime does not.
+1 -1
View File
@@ -138,7 +138,7 @@ do_link (const char *source, const char *dest)
{
/* Which stat to use depends on whether linkat will follow the
symlink. We can't use the shorter
(logical ? stat : lstat) (source, &source_stats)
(logical?stat:lstat) (source, &source_stats)
since stat might be a function-like macro. */
if ((logical ? stat (source, &source_stats)
: lstat (source, &source_stats))
+1 -1
View File
@@ -903,7 +903,7 @@ do_stat (char const *filename, bool terse, char const *format)
}
}
/* We can't use the shorter
(follow_links ? stat : lstat) (filename, &statbug)
(follow_links?stat:lstat) (filename, &statbug)
since stat might be a function-like macro. */
else if ((follow_links
? stat (filename, &statbuf)
+1 -1
View File
@@ -348,7 +348,7 @@ main (int argc, char **argv)
if (use_ref)
{
struct stat ref_stats;
/* Don't use (no_dereference ? lstat : stat) (args), since stat
/* Don't use (no_dereference?lstat:stat) (args), since stat
might be an object-like macro. */
if (no_dereference ? lstat (ref_file, &ref_stats)
: stat (ref_file, &ref_stats))