mirror of
https://git.savannah.gnu.org/git/coreutils.git
synced 2026-11-19 03:33:43 +03:00
Work around AFS bug: id and groups would print invalid group number.
* src/id.c (main): Call print_group_list with a user name, if possible. * src/groups.c (main): Likewise. * NEWS: Mention this. For details, see http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/12852 http://thread.gmane.org/gmane.comp.gnu.coreutils.bugs/12875 Signed-off-by: ribalba <geerd.dietger.hoffmann@gmail.com>
This commit is contained in:
1 parent
f5d58041d5
commit
b7a836c0a3
3 files changed
+12
-4
No files matched your search
@@ -31,6 +31,9 @@ GNU coreutils NEWS -*- outline -*-
|
||||
|
||||
** Improvements
|
||||
|
||||
id and groups work around an AFS-related bug whereby those programs
|
||||
would print an invalid group number, when given no user-name argument.
|
||||
|
||||
ls --color no longer outputs unnecessary escape sequences
|
||||
|
||||
seq gives better diagnostics for invalid formats.
|
||||
|
||||
+1
-1
@@ -102,7 +102,7 @@ main (int argc, char **argv)
|
||||
egid = getegid ();
|
||||
rgid = getgid ();
|
||||
|
||||
if (!print_group_list (NULL, ruid, rgid, egid, true))
|
||||
if (!print_group_list (getlogin (), ruid, rgid, egid, true))
|
||||
ok = false;
|
||||
putchar ('\n');
|
||||
}
|
||||
|
||||
@@ -196,17 +196,22 @@ of a different user"));
|
||||
error (EXIT_FAILURE, 0,
|
||||
_("cannot print only names or real IDs in default format"));
|
||||
|
||||
char const *user_name;
|
||||
if (argc - optind == 1)
|
||||
{
|
||||
struct passwd *pwd = getpwnam (argv[optind]);
|
||||
struct passwd const *pwd = getpwnam (argv[optind]);
|
||||
if (pwd == NULL)
|
||||
error (EXIT_FAILURE, 0, _("%s: No such user"), argv[optind]);
|
||||
user_name = argv[optind];
|
||||
ruid = euid = pwd->pw_uid;
|
||||
rgid = egid = pwd->pw_gid;
|
||||
}
|
||||
else
|
||||
{
|
||||
struct passwd const *pwd;
|
||||
euid = geteuid ();
|
||||
pwd = getpwuid (euid);
|
||||
user_name = pwd ? pwd->pw_name : NULL;
|
||||
ruid = getuid ();
|
||||
egid = getegid ();
|
||||
rgid = getgid ();
|
||||
@@ -223,7 +228,7 @@ of a different user"));
|
||||
}
|
||||
else if (just_group_list)
|
||||
{
|
||||
if (!print_group_list (argv[optind], ruid, rgid, egid, use_name))
|
||||
if (!print_group_list (user_name, ruid, rgid, egid, use_name))
|
||||
ok = false;
|
||||
}
|
||||
else if (just_context)
|
||||
@@ -232,7 +237,7 @@ of a different user"));
|
||||
}
|
||||
else
|
||||
{
|
||||
print_full_info (argv[optind]);
|
||||
print_full_info (user_name);
|
||||
}
|
||||
putchar ('\n');
|
||||
|
||||
|
||||
Reference in new issue
Block a user