cp,mv,install: fix chmod on Linux CIFS

This bug occurs only when temporarily setting the mode to the
intersection of old and new modes when changing ownership.
* src/copy.c (owner_failure_ok): Treat EACCES like EPERM.
This commit is contained in:
Paul Eggert committed 2023-09-02 13:28:23 -07:00
1 parent 5f97136160
commit 9cd52bd999
2 files changed
+5 -4

No files matched your search

+3 -3
View File
@@ -4,9 +4,9 @@ GNU coreutils NEWS -*- outline -*-
** Bug fixes
cp, mv, install no longer issue spurious "failed to preserve ownership"
diagnostics when copying to GNU/Linux CIFS filesystems. They do
this by working around a Linux CIFS bug.
cp, mv, and install no longer issue spurious diagnostics like "failed
to preserve ownership" when copying to GNU/Linux CIFS file systems.
They do this by working around some Linux CIFS bugs.
numfmt options like --suffix no longer have an arbitrary 127-byte limit.
[bug introduced with numfmt in coreutils-8.21]
+2 -1
View File
@@ -3468,7 +3468,8 @@ chown_failure_ok (struct cp_options const *x)
static bool
owner_failure_ok (struct cp_options const *x)
{
return ((errno == EPERM || errno == EINVAL) && !x->owner_privileges);
return ((errno == EPERM || errno == EINVAL || errno == EACCES)
&& !x->owner_privileges);
}
/* Return the user's umask, caching the result.