maint: fix wildcard quoting in sc_tests_executable

* cfg.mk (sc_tests_executable): If there are files with
$TEST_EXTENSIONS in the current directory, then the
lack of quoting of the $test_extensions_rx contents
could result in globbing and an inconsequential run.
find(1) produces warnings only with more than one expansion.
This commit is contained in:
Pádraig Brady committed 2015-03-20 01:16:06 +00:00
1 parent 1025243b6a
commit 79e27fd67e
1 file changed
+3 -4
+3 -4
View File
@@ -116,10 +116,9 @@ sc_tests_list_consistency:
# Ensure that all version-controlled test scripts are executable.
sc_tests_executable:
@test_extensions_rx=`echo $(TEST_EXTENSIONS) \
| sed -e "s/ / -o -name */g" -e "s/^/-name */"`; \
find tests/ \( $$test_extensions_rx \) \! -perm -u+x -print \
| sed -e "s/^/$(ME): Please make test executable: /" | grep . \
@test_extensions_rx=`printf -- "-name '*%s' " $(TEST_EXTENSIONS)`;\
find tests/ \( $$test_extensions_rx \) \! -perm -u+x -print \
| sed -e "s/^/$(ME): Please make test executable: /" | grep . \
&& exit 1; :
# Ensure all gnulib patches apply cleanly