mirror of
https://git.savannah.gnu.org/git/coreutils.git
synced 2026-11-17 18:02:09 +03:00
factor: use 1-word code only when tested
* src/factor.c (print_factors): Use single-precision code only when word size is 32 or 64, as it isn't tested for other sizes and is known to not work when it the size is 128. This change does not affect any known practical platforms.
This commit is contained in:
1 parent
8eb114f080
commit
4e2aeb31e0
1 file changed
+10
-2
+10
-2
@@ -2308,8 +2308,16 @@ print_factors (char const *input)
|
||||
|
||||
switch (err)
|
||||
{
|
||||
case LONGINT_OK:
|
||||
if (hi (u) >> (W_TYPE_SIZE - 1) == 0)
|
||||
case LONGINT_OK:;
|
||||
/* Use single-precision code only when W_TYPE_SIZE is 32 or 64,
|
||||
as <https://bugs.gnu.org/78476> suggests that it fails when
|
||||
W_TYPE_SIZE is 128 and the code has not been well tested with
|
||||
other values. FIXME: Either remove the single-precision
|
||||
code, or fix its assumptions about W_TYPE_SIZE, perhaps by
|
||||
using Baille-PSW as suggested in a FIXME above. */
|
||||
enum { SINGLE_WORKS = W_TYPE_SIZE == 32 || W_TYPE_SIZE == 64 };
|
||||
|
||||
if (SINGLE_WORKS && hi (u) >> (W_TYPE_SIZE - 1) == 0)
|
||||
{
|
||||
devmsg ("[using single-precision arithmetic] ");
|
||||
print_factors_single (u);
|
||||
|
||||
Reference in new issue
Block a user