1
0
mirror of https://github.com/quay/quay.git synced 2026-01-26 06:21:37 +03:00
Commit Graph

12664 Commits

Author SHA1 Message Date
red-hat-konflux[bot]
fdf776f347 chore(deps): update dependency python-swiftclient to v4.9.0
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
2026-01-06 01:20:57 +00:00
jbpratt
c6eb6b573d test(web): migrate more tests to playwright (#4773)
* test(web): migrate superuser-org-actions.cy.ts to Playwright

Migrate Cypress E2E tests for superuser organization actions to Playwright
following the project's MIGRATION.md guidelines.

Changes:
- Add new test file: playwright/e2e/superuser/org-actions.spec.ts
- Consolidate 12 Cypress tests into 5 focused Playwright tests
- Use real API data instead of mocked fixtures
- Auto-cleanup via TestApi fixture

Test coverage:
- Superuser sees actions column and options menu for organizations
- Regular user does not see organization options menu
- Superuser can rename organization
- Superuser can delete organization
- Superuser can take ownership of organization

Skipped from migration:
- Quota menu tests (already covered by quota.spec.ts)
- Fresh login requirement tests (low value, complex to mock)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* test(web): set superuser feature tag

Signed-off-by: Brady Pratt <bpratt@redhat.com>

* test(web): migrate superuser-messages.cy.ts to Playwright

Migrate superuser messages tests from Cypress to Playwright, consolidating
14 original tests into 6 focused, value-add tests.

Tests cover:
- Non-superuser redirect to organization page
- Full CRUD flow: create, view, and delete messages via UI
- Error state when API fails to load messages
- Loading spinner during message fetch
- Read-only superuser can access and view messages
- Read-only superuser sees disabled create/delete actions

Infrastructure additions:
- Add message() method to TestApi with auto-cleanup
- Add CreatedMessage interface for type safety
- Add SUPERUSERS_FULL_ACCESS feature tag

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* test(web): migrate superuser-user-management.cy.ts to Playwright

Consolidates 29 Cypress tests into 11 Playwright tests covering
superuser user management functionality.

Changes:
- Add CreatedUser interface and user() method to TestApi for
  user creation with auto-cleanup
- Add createUserAsSuperuser() to API client using superuser endpoint
- Add QuayAuthType and skipUnlessAuthType() helper for auth-type
  conditional tests
- Create user-management.spec.ts with consolidated tests

Tests cover:
- Create user via UI (Database/AppToken auth only)
- User access control based on user type
- Change email and password (Database auth only)
- Toggle user status (disable/enable)
- Delete user
- Take ownership (convert user to org)
- Fresh login error handling with mocked responses
- Send recovery email (MAILING feature)
- Auth type visibility

Key patterns:
- Uses search to find users in paginated list
- page.route() only for error scenarios per MIGRATION.md
- skipUnlessAuthType() for auth-dependent tests
- @feature:SUPERUSERS_FULL_ACCESS tag for all tests

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* test(web): delete more migrated cypress tests

Signed-off-by: Brady Pratt <bpratt@redhat.com>

* test(web): migrate superuser-framework Cypress test to Playwright

Consolidates 7 Cypress tests into 4 Playwright tests covering:
- Superuser navigation to all superuser pages
- Navigation section visibility and expansion
- Organizations table Settings column and actions menu
- Regular user restrictions and redirects

Uses real superuserPage/authenticatedPage fixtures instead of mocking.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* test(web): migrate superuser-service-keys Cypress test to Playwright

Consolidates 17 Cypress tests into 5 Playwright tests:
- non-superuser redirect to organization page
- superuser CRUD lifecycle (create, view, search, update, delete)
- error handling when create fails
- read-only superuser permission restrictions
- bulk select and delete operations

Adds service key API methods to Playwright test utilities:
- getServiceKeys, createServiceKey, updateServiceKey, deleteServiceKey
- TestApi.serviceKey() with auto-cleanup support

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* test(web): migrate superuser-change-log Cypress test to Playwright

Migrate superuser-change-log.cy.ts to Playwright with test consolidation:
- 7 original tests reduced to 2 focused tests
- Access control tests already covered by framework.spec.ts
- Loading spinner and empty state tests skipped (low value)
- Uses real API calls except for error state (acceptable mock)
- No PatternFly class dependencies, uses role-based selectors

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* test(web): migrate superuser-usage-logs Cypress test to Playwright

- Consolidate 7 Cypress tests into 2 Playwright tests
- Access control tests already covered by framework.spec.ts
- Add data-testid="usage-logs-table" to UsageLogsTable component
- Tests verify: page header, date pickers, chart toggle, table loading,
  and filter functionality
- Use structural assertions for parallel test safety

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Brady Pratt <bpratt@redhat.com>

* test(web): remove unneeded comments

Signed-off-by: Brady Pratt <bpratt@redhat.com>

---------

Signed-off-by: Brady Pratt <bpratt@redhat.com>
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-05 17:54:25 -06:00
jbpratt
c53a584264 fix(web): prevent signin page redirect loop (PROJQUAY-10090) (#4770)
When FEATURE_ANONYMOUS_ACCESS is disabled, API calls like /api/v1/messages
return 401. The axios interceptor was unconditionally redirecting to /signin
on 401 errors, causing an infinite loop when already on auth pages.

Now checks if on /signin, /createaccount, or /oauth before redirecting.

Signed-off-by: Brady Pratt <bpratt@redhat.com>
Co-authored-by: Claude <noreply@anthropic.com>
2026-01-05 16:27:04 -06:00
Ryan Wallace
225f28f507 chore(deps): upgrade redis version, remove redis-py-cluster (PROJQUAY-9314) (#4703)
* chore(deps): upgrade redis version, remove redis-py-cluster

* chore: adjust deps

* test: adjust tests

* docs: add comments about backwards compatible conversions
2026-01-05 21:02:43 +00:00
Sunandadadi
79a628cd85 fix(web): display correct robot account permissions in modal (PROJQUAY-10084) (#4766)
* fix(web): display correct robot account permissions in modal (PROJQUAY-10084)

Fix race condition in DropdownWithDescription where the permission
dropdown was incorrectly defaulting to 'Read' when loading existing
robot account permissions.

The issue occurred because rows were being marked as selected before
the actual permission values were loaded, causing the dropdown to
trigger its default 'Read' behavior.

The fix:
- Prioritize valid permission values when they exist
- Only default to 'Read' when user manually selects a row (isUserEntry=true)
- Do not default to 'Read' during auto-selection from loading existing perms

Also adds Playwright tests to verify:
- Initial permission displays correctly
- Write permission displays correctly (not defaulting to Read)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* fix(web): pass isWizardStep to dropdown for proper permission defaults (PROJQUAY-10084)

- Pass isWizardStep prop from AddToRepository to DropdownWithDescription
- In wizard mode, always default to 'Read' when a row is selected
- In non-wizard mode (robot permissions modal), only show actual values
- Fix prettier formatting in robot-accounts.spec.ts

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* minor fix

---------

Co-authored-by: Claude <noreply@anthropic.com>
2026-01-05 20:32:33 +00:00
Ryan Wallace
258735742b chore: remove unused git sha code (#4771)
* chore: remove displayversion.py

This code is unused so we can remove it

* chore(.dockerignore): remove git HEAD inclusion rule

* chore(_init.py): remove _get_git_sha method
2026-01-05 18:45:44 +00:00
jbpratt
0638c19183 test(web): migrate more tests to playwright (#4767)
* test(web): migrate repository-autopruning to Playwright

Consolidate 17 Cypress tests into 6 Playwright tests:
- policy lifecycle (create, update, delete)
- policy with tag pattern filter
- multiple policies lifecycle
- namespace policy display in repository settings
- registry policy display
- error handling (load failure)

Uses @feature:AUTO_PRUNE tag for automatic test skipping.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* test: enable features by default

Signed-off-by: Brady Pratt <bpratt@redhat.com>

* test(web): migrate create-account.cy.ts to Playwright

Migrates the Create Account Cypress tests to Playwright following
the MIGRATION.md guide:

- Consolidates 10 Cypress tests into 6 focused Playwright tests
- Uses real API calls instead of mocks
- Adds data-testid attributes to CreateAccount component
- Uses @feature:MAILING and @feature:QUOTA_MANAGEMENT tags
  to skip tests when features are not enabled
- Creates custom fixtures for unauthenticated page access
- Implements proper user cleanup after tests

Tests:
- form validation prevents invalid submissions
- creates account with valid inputs and redirects
- shows error for existing username
- navigates to signin page via link
- shows verification message (requires MAILING)
- redirects to updateuser (requires QUOTA_MANAGEMENT)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Signed-off-by: Brady Pratt <bpratt@redhat.com>

* chore(dev) add Mailpit for local email testing

Add Mailpit email testing server to the local development environment
to enable testing of FEATURE_MAILING functionality with Playwright.

Changes:
- Add mailpit service to docker-compose.yaml (ports 8025/1025)
- Enable FEATURE_MAILING and configure SMTP settings in config.yaml
- Add mailpit utilities to Playwright fixtures (getEmails, clearInbox,
  waitForEmail, getEmailBody, isAvailable)

Usage:
  podman-compose up mailpit -d
  # Access Web UI at http://localhost:8025

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

* test(web) use mailpit helpers for email confirmation support

Test updates:
- "creates account and redirects to organization" now confirms email
- "redirects to updateuser when user has prompts" now confirms email
- Tests detect FEATURE_MAILING at runtime and adapt accordingly
- Email search uses recipient address for parallel test safety

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Signed-off-by: Brady Pratt <bpratt@redhat.com>

* test(web): use mailpit for email notification test

Replace mocked email authorization with real Mailpit verification
in the notifications.spec.ts test.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Signed-off-by: Brady Pratt <bpratt@redhat.com>

* test(web): mock user response in cypress test

this broke when mailing was enabled

Signed-off-by: Brady Pratt <bpratt@redhat.com>

---------

Signed-off-by: Brady Pratt <bpratt@redhat.com>
Co-authored-by: Claude <noreply@anthropic.com>
2026-01-05 09:47:29 -08:00
Shaon H
8485956048 fix(web): display layers for multi-arch manifests (PROJQUAY-10020) (#4761)
When viewing a child manifest of a multi-architecture image, the Layers
tab was showing "No layers found" because manifestData was fetched for
the parent manifest list digest (which has no layers) but never
re-fetched when the user selected a specific architecture.

Fix: Make the Layers component fetch its own manifest data based on the
digest prop using a new useManifestByDigest hook. This ensures layers
are fetched for the correct child manifest digest.

Changes:
- Add useManifestByDigest hook using React Query
- Update Layers component to fetch manifest data internally
- Remove manifestData prop from Layers in TagDetailsTabs
- Add Playwright e2e tests for multi-arch manifest layers

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-05 09:42:32 -08:00
jbpratt
f35a2a7078 chore: add reusable composite action for local dev stack (#4763)
ci: add reusable composite action for local dev stack

Create setup-quay composite action to standardize CI environment setup:
- Docker image build with GHA cache support
- Database services startup via docker-compose
- Robust curl-based health checks with configurable timeout
- Optional extra config, and Clair support
- Automatic debug log collection and artifact upload on failure

Migrate web-playwright-ci.yaml to use the new action

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Signed-off-by: Brady Pratt <bpratt@redhat.com>
Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-05 09:11:34 -06:00
jbpratt
e21a9caae2 test(web): fix service-keys tests failing due to past expiration dates (#4768)
Replace hardcoded expiration date '2025-12-31T23:59' with dynamically
generated future date. The tests were failing with "Expiration date
must be in the future" validation error since it's now 2026.

Added getFutureExpirationDate() helper that returns a date 1 year
from now in the required datetime-local format.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2026-01-02 17:21:30 -05:00
jbpratt
ef1974688e test(web): migrate more tests to playwright (#4762)
* test(web): migrate repository-shorthand-navigation to Playwright

Migrate Cypress shorthand URL navigation tests to Playwright with real
resources instead of mocked API responses. Consolidates 11 tests into 7.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* test(web): migrate repository-permissions to Playwright

Migrate repository-permissions.cy.ts to Playwright, consolidating
6 Cypress tests into 3 Playwright tests covering:
- Inline permission display, change, and delete operations
- Bulk permission change and delete operations
- Adding permissions for robots and teams

Changes:
- Add repository permission API utilities to client.ts
- Add api.repositoryPermission() helper with auto-cleanup
- Add data-testid attributes to PermissionsToolbar and AddPermission
- Update MIGRATION.md checklist (11 migrated, 20%)

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* test(web): migrate repository-notifications to Playwright

Migrate 18 Cypress tests from repository-notifications.cy.ts to 7
consolidated Playwright tests covering notification CRUD operations,
bulk actions, and recipient field functionality.

Changes:
- Add notification API utilities to client.ts
- Add notification() method to TestApi for auto-cleanup
- Add IMAGE_EXPIRY_TRIGGER to QuayFeature type
- Add data-testid attributes to notification form components
- Create notifications.spec.ts with 7 focused tests

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* test(web): migrate repositories-list to Playwright

Migrate repositories-list.cy.ts from Cypress to Playwright, consolidating
11 tests into 6 focused e2e tests:

- displays repositories in global and organization views
- creates repositories with different visibility and namespaces
- deletes multiple repositories via bulk action
- changes visibility for multiple repositories
- searches by name and supports regex mode
- searches by name including organization

Skipped pagination tests (test PatternFly, not app code).

Added data-testid attributes:
- CreateRepoModalTemplate: form inputs, visibility radios, buttons
- BulkDeleteModalTemplate: modal, confirmation input
- RepositoryToolBar: visibility confirmation buttons

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* test(web): migrate robot-accounts to Playwright

Migrate robot-accounts.cy.ts from Cypress to Playwright, consolidating
12 tests into 4 focused e2e tests:

- CRUD lifecycle: create, search, toolbar, and delete robot account
- robot credentials and Kubernetes secrets
- robot repository permissions: update single permission
- robot wizard: org has 5 steps, user namespace has 3 steps

Added data-testid attributes:
- CreateRobotAccountModal: modal container
- RobotTokensModal: regenerate button, token display, docker/podman commands
- robotAccountWizard: step navigation, name/description inputs
- ExpandCollapseButton, SearchInput, ToolbarButton: pass-through testid
- RobotAccountKebab: menu items for permissions, tokens, delete
- RobotAccountsList: table container

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* test(web): remove migrated cypress tests

Signed-off-by: Brady Pratt <bpratt@redhat.com>

---------

Signed-off-by: Brady Pratt <bpratt@redhat.com>
Co-authored-by: Claude <noreply@anthropic.com>
2026-01-02 13:37:05 -05:00
jbpratt
5a86c7a57f test(web): migrate some tests and improve framework (#4760)
* test(web): migrate logout Cypress test to Playwright

Uses unique temporary users per test to avoid session invalidation
conflicts when running in parallel. Quay's signout endpoint invalidates
all sessions for a user, which would break parallel tests sharing users.

Also documents the session-destructive test pattern in MIGRATION.md.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* test(web): migrate mirroring Cypress test to Playwright

Migrates web/cypress/e2e/mirroring.cy.ts to Playwright following the
MIGRATION.md guide. Consolidates 18 Cypress tests into 5 Playwright
tests using real API calls instead of mocks.

Changes:
- Add mirroring API utilities to client.ts (changeRepositoryState,
  createMirrorConfig, getMirrorConfig, updateMirrorConfig,
  triggerMirrorSync, cancelMirrorSync)
- Create mirroring.spec.ts with 5 consolidated tests covering:
  - State warning and form visibility
  - New mirror configuration lifecycle
  - Existing mirror configuration management
  - Sync operations
  - Error handling (only mock used for 400 error scenario)
- Update MIGRATION.md checklist (8/54, 15%)

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>

* test(web): add TestApi fixture with auto-cleanup for Playwright tests

Introduce a TestApi class that wraps ApiClient and automatically tracks
created resources for cleanup after each test. This eliminates the need
for manual beforeEach/afterEach cleanup patterns and ensures resources
are always cleaned up even when tests fail.

Changes:
- Add TestApi class to fixtures.ts with methods for creating orgs,
  repos, teams, robots, and prototypes with auto-cleanup
- Add api and superuserApi fixtures that provide TestApi instances
- Migrate all committed Playwright tests to use the new api fixture
- Update MIGRATION.md with documentation for the new pattern

The api fixture provides:
- api.organization(prefix?) - creates org with unique name
- api.repository(namespace?, prefix?, visibility?) - creates repo
- api.team(orgName, prefix?, role?) - creates team
- api.robot(orgName, prefix?, description?) - creates robot
- api.prototype(orgName, role, delegate, activatingUser?) - creates default permission
- api.setMirrorState(namespace, repoName) - sets repo to MIRROR state
- api.raw - access underlying ApiClient for non-tracked operations

Resources are cleaned up in reverse order (LIFO) after each test.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* test(web): remove migrated tests

Signed-off-by: Brady Pratt <bpratt@redhat.com>

* test(web): auto-skip Playwright tests based on @feature: tags

Adds an auto-fixture to fixtures.ts that automatically skips tests
when their @feature:X tags reference disabled Quay features. This
eliminates duplication between tags and manual test.skip() calls.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* fix(web): set axios baseURL at module level for all routes (PROJQUAY-0000)

Previously axios baseURL was only set inside StandaloneMain component,
causing requests from /signin and other auth routes to go to the wrong
URL (localhost:9000 instead of localhost:8080).

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* test(web): use cy.session() for Cypress authentication

Replace manual CSRF token + loginByCSRF pattern with cy.session()
for proper session handling. Fixes race condition where React app
made API calls before Cypress login completed.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* test(web): fix notification drawer test flakiness with toPass polling

Use Playwright's toPass to poll for notification appearance instead of
a single assertion. The backend may take time to process push
notifications, so reload and retry until the notification is visible.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

---------

Signed-off-by: Brady Pratt <bpratt@redhat.com>
Co-authored-by: Claude <noreply@anthropic.com>
2025-12-23 16:35:54 -06:00
Dave O'Connor
2cb6ace5b6 docs: add AI agent documentation with progressive disclosure (PROJQUAY-9897) (#4752) 2025-12-19 16:02:02 -05:00
Ryan Wallace
a06cc6fa43 chore: update all black versions to 24.4.2 and run make black (#4754)
* chore(pre-commit): match black version with requirements-dev

* run `make black` against repo

* ci: switch to black 24.4.2

* fix: py312

* fix: flake8 errors

* fix: flake8 conflicts

* chore: add git blame ignore revs file
2025-12-19 11:29:53 -06:00
shaonrh
0f2f96a514 chore: update Makefile DOCKER variable and pre-commit version (PROJQUAY-10071) (#4755)
* chore: update Makefile DOCKER variable and pre-commit version (PROJQUAY-10071)

Replace hardcoded docker command with $(DOCKER) variable and update
pre-commit installation to version 4.5.0 in Makefile and documentation.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
2025-12-19 08:52:20 -08:00
jbpratt
bab1d97eda chore(ci): add Docker build cache to Playwright workflow (#4748)
Enable GitHub Actions cache for Docker builds to speed up Playwright
E2E test runs. Uses mode=max to cache all intermediate layers from
the multi-stage Dockerfile.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude <noreply@anthropic.com>
2025-12-18 15:27:08 +00:00
jbpratt
05495a2995 test(web): migrate more tests to playwright (#4741)
* test(web): migrate notification-drawer Cypress test to Playwright

Convert the notification-drawer.cy.ts test from mocked API responses to
real API interactions. The test now creates a repository, configures a
quay_notification for repo_push events, pushes an image to trigger the
notification, then validates the drawer UI behavior (open, read, delete).

Adds createRepositoryNotification method to the Playwright API client.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* test(web): migrate default-permissions Cypress test to Playwright

- Add robot and prototype API methods to test client
- Fix undefined allMembers bug in CreateTeamWizard.tsx
- Fix missing return value in AddTeamMember.tsx setDeletedTeamMembers
- Tests run in parallel with isolated state per test

Co-authored-by: Claude <noreply@anthropic.com>

* test(web): migrate external-scripts Cypress test to Playwright

Co-authored-by: Claude <noreply@anthropic.com>

---------

Co-authored-by: Claude <noreply@anthropic.com>
2025-12-17 18:51:53 -05:00
Kenny Lee Sin Cheong
c24a2fd22f metrics: rename namespace label to avoid conflict (PROJQUAY-9388) (#4746)
Rename namespace label to avoid conflict
2025-12-17 18:18:02 +00:00
Dave O'Connor
a836de5f16 chore: update pre-commit to 4.5.0 (PROJQUAY-10028) (#4744)
chore: update pre-commit to 4.5.0

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
2025-12-17 09:53:10 +00:00
jbpratt
2c14bcadf5 fix(web): hide the overview route for on prem (PROJQUAY-0000) (#4737)
fix(web): hide the overview route for on prem

Signed-off-by: Brady Pratt <bpratt@redhat.com>
2025-12-16 11:09:11 -06:00
jbpratt
0ac8499067 test(web): consolidate Playwright API utils into ApiClient class (#4739)
* test(web): consolidate Playwright API utils into ApiClient class

Migrate from individual function-based API utilities to a unified
ApiClient class with CSRF token caching. This eliminates redundant
token requests when tests make multiple API calls.

Key changes:
- Create ApiClient class with cached CSRF token
- Add signIn() method for authentication flows
- Update all test files to use ApiClient instances
- Remove individual api/csrf.ts, organization.ts, repository.ts,
  team.ts, user.ts files in favor of single client.ts
- Update fixtures.ts to use ApiClient for login

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Brady Pratt <bpratt@redhat.com>

* test(web): run playwright on small machine for chrome only

while we are migrating, swap things around to save time and money

Signed-off-by: Brady Pratt <bpratt@redhat.com>

---------

Signed-off-by: Brady Pratt <bpratt@redhat.com>
Co-authored-by: Claude <noreply@anthropic.com>
2025-12-16 14:56:43 +00:00
jbpratt
c52deaa6b3 test(web): migrate some cypress tests to playwright (#4734)
* test(web): migrate theme-switcher tests from Cypress to Playwright

Replace Cypress theme-switcher.cy.ts with Playwright equivalent.
Uses real API calls instead of mocked intercepts per migration guide.
Tests theme toggle visibility, persistence, and browser color scheme
detection via Playwright's emulateMedia API.

- Add data-testid to user-menu-toggle for stable selector
- Create playwright/e2e/ui/theme-switcher.spec.ts with 3 test cases
- Update MIGRATION.md checklist (2/54 migrated)
- Delete original Cypress test file

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* test(web): migrate breadcrumbs tests from Cypress to Playwright

Add organization, team, and container API utilities to support the
breadcrumbs test migration. Tests cover:
- List pages (no breadcrumbs)
- Organization, repository, tag, and team page breadcrumbs
- Edge cases with same-name org/repo/team combinations

The container utility supports both podman and docker for pushing
test images when testing tag breadcrumbs.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* test(web): migrate overview tests from Cypress to Playwright

Migrates web/cypress/e2e/overview.cy.ts to Playwright with 4 tests:
- Expandable dropdowns show content
- External links navigate correctly
- Tabs switch content correctly
- Purchase plans dropdown shows pricing options

Uses getByRole for tab selection instead of PatternFly-generated IDs.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Brady Pratt <bpratt@redhat.com>

* test(ci): ignore test files for web preview

no need in deploying the web preview if only tests or docs are modified

Signed-off-by: Brady Pratt <bpratt@redhat.com>

---------

Signed-off-by: Brady Pratt <bpratt@redhat.com>
Co-authored-by: Claude <noreply@anthropic.com>
2025-12-15 18:58:23 -06:00
Kenny Lee Sin Cheong
ef0d082ff1 deploy: add missing configmap from grafana dashboard (PROJQUAY-9388) (#4735)
deploy: add missing configmap from grafana dashboard
2025-12-15 20:16:12 +00:00
Kenny Lee Sin Cheong
1749e9ac59 deploy: update SLO dashboard (PROJQUAY-9388) (#4722)
deploy: update SLO dashboard
2025-12-15 11:56:19 -05:00
jbpratt
963a90ecdd fix(ldap): eliminate redundant conn in user search methods (PROJQUAY-7057) (#4720)
Each LDAP user search was creating two connections: one just to verify
admin credentials worked, then another for the actual search. This
doubled the load on LDAP servers. Consolidated into a single connection
block with proper error handling for INVALID_CREDENTIALS.

Affected methods:
- _ldap_user_search(): Core search used by most LDAP operations
- at_least_one_user_exists(): User existence checks

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Signed-off-by: Brady Pratt <bpratt@redhat.com>
Co-authored-by: Claude <noreply@anthropic.com>
2025-12-15 09:56:03 -06:00
jbpratt
1bde727a49 chore(web): playwright ci improvements with caching/reporting (#4731)
* test(ci,web): add Playwright report deployment to Surge.sh

- Switch Playwright workflow to use large self-hosted runner
  (quay-001-large-ubuntu-24-x64) for faster execution
- Add new workflow to deploy HTML reports to Surge.sh
- Post PR comments with test status and link to full report
- Report accessible at quay-playwright-pr-{PR_NUMBER}.surge.sh
- Add cleanup workflow to teardown report on PR close

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

* chore(ci): drop gha caching

it is slow and no tworking

Signed-off-by: Brady Pratt <bpratt@redhat.com>

* test(ci,web): cache Playwright browser binaries

Cache ~/.cache/ms-playwright between CI runs to avoid re-downloading
browsers on every workflow run. Cache key is based on Playwright
version from package-lock.json and auto-invalidates on version bumps.

On cache hit, only OS dependencies are installed (~45s).
On cache miss, full browser + deps install occurs.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Brady Pratt <bpratt@redhat.com>

---------

Signed-off-by: Brady Pratt <bpratt@redhat.com>
Co-authored-by: Claude <noreply@anthropic.com>
2025-12-15 09:59:08 -05:00
dependabot[bot]
312638673c chore(deps): bump golang.org/x/crypto from 0.40.0 to 0.45.0 in /config-tool (#4727)
chore(deps): bump golang.org/x/crypto in /config-tool

Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.40.0 to 0.45.0.
- [Commits](https://github.com/golang/crypto/compare/v0.40.0...v0.45.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-version: 0.45.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
2025-12-14 18:34:06 -06:00
jbpratt
69b7aff5b4 chore: add Playwright e2e test infrastructure (#4688)
* chore: add Playwright e2e test infrastructure

Add Playwright test framework with custom fixtures for authenticated
contexts, API utilities for test data management, and repository
delete test as initial migration from Cypress.

Key additions:
- global-setup.ts: Creates admin, testuser, readonly test users
- fixtures.ts: Pre-authenticated page/request fixtures by role
- utils/api.ts: CRUD utilities for repositories
- MIGRATION.md: Guide for migrating Cypress tests to Playwright
- repository-delete.spec.ts: First migrated test with full cleanup

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Brady Pratt <bpratt@redhat.com>

* chore: update web/.dockerignore

exclude tests from being included in the intermediate build - this
should improve caching when only tests change

Signed-off-by: Brady Pratt <bpratt@redhat.com>

* chore: add pre-commit check to block new cypress tests

Signed-off-by: Brady Pratt <bpratt@redhat.com>

---------

Signed-off-by: Brady Pratt <bpratt@redhat.com>
Co-authored-by: Claude <noreply@anthropic.com>
2025-12-12 18:40:38 -06:00
red-hat-konflux[bot]
257078a08b chore(deps): update dependency jws to v4.0.1 (#4713)
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>
2025-12-12 11:56:38 -06:00
jbpratt
c51c99e839 fix(nginx): route /buildlogs to backend for React UI (PROJQUAY-6767) (#4725)
The download button on the Build Logs page in the new React UI was
returning 404 because /buildlogs/<build_uuid> requests were not being
proxied to the Flask backend. This adds /buildlogs to the nginx proxy
pass regex pattern so the endpoint is accessible when using React UI.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude <noreply@anthropic.com>
2025-12-12 14:27:38 +00:00
Ryan Wallace
40d9458053 fix(sentry): filter out repo metadata when sending events (PROJQUAY-9436) (#4723)
fix(sentry): filter out repo metadata when sending events
2025-12-11 15:54:33 -05:00
Harish Govindarajulu
5a0d7efecd fix(ui): add label to show global readonly superuser in organizations list (PROJQUAY-9970) (#4717)
This commit adds a cyan "Global Readonly Superuser" label to identify
global readonly superusers in the Organizations list, making it easier
for administrators to distinguish them from regular superusers.

Backend change: Updated User.to_dict() to include global_readonly_super_user
property in the /api/v1/superuser/users/ API response.

Frontend changes: Propagated the property through the data flow and added
label rendering with cyan color to visually distinguish from regular
superusers (blue).

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude Sonnet 4.5 <noreply@anthropic.com>
2025-12-11 14:44:28 -06:00
jbpratt
c06e123a12 chore: remove dependabot configuration (#4719)
we are a mintmaker team

Signed-off-by: Brady Pratt <bpratt@redhat.com>
2025-12-11 18:20:48 +00:00
jbpratt
95b4ee4656 test(web): mark usage logs test as skipped due to flake (#4718)
test(web): skip flaky test

will follow up fixing it, its breaking CI all over

Signed-off-by: Brady Pratt <bpratt@redhat.com>
2025-12-11 11:30:38 -06:00
red-hat-konflux[bot]
63515d6118 chore(deps): update dependency @types/react-redux to v6.0.28 (#4467)
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>
2025-12-10 19:46:06 -06:00
red-hat-konflux[bot]
40835d08f1 chore(deps): update dependency karma to v6.4.4 (#4473)
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>
2025-12-10 19:01:30 -06:00
red-hat-konflux[bot]
7f43e36e63 chore(deps): update dependency karma-webpack to v5.0.1 (#4474)
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>
2025-12-10 19:01:05 -06:00
red-hat-konflux[bot]
2b516804bb chore(deps): update dependency furl to v2.1.4 (#4468)
Signed-off-by: red-hat-konflux <126015336+red-hat-konflux[bot]@users.noreply.github.com>
Co-authored-by: red-hat-konflux[bot] <126015336+red-hat-konflux[bot]@users.noreply.github.com>
2025-12-10 18:59:54 -06:00
jbpratt
8593006231 fix(web): sort Build ID column numerically as hex values (PROJQUAY-9895) (#4701)
Build IDs are UUIDs displayed as hex strings. The previous localeCompare
sorting treated them lexicographically, causing incorrect sort order.
Now detects hex/UUID patterns and sorts by parsing the first 8 hex
digits numerically.

Co-authored-by: Claude <noreply@anthropic.com>
2025-12-10 04:26:51 -06:00
jbpratt
ced2c6ffa8 feat(endpoints,web): add audit logs for quota configuration (PROJQUAY-9859) (#4692)
Adds audit logging for all quota management operations:
- org_create_quota, org_change_quota, org_delete_quota
- org_create_quota_limit, org_change_quota_limit, org_delete_quota_limit

Backend changes:
- Add LogEntryKind types in initdb.py
- Add log_action calls in namespacequota.py endpoints
- Add Alembic migration for new log kinds
- Add unit tests for audit logging

Frontend changes:
- Add log descriptions in UseLogDescriptions.tsx
- Add Cypress e2e test for quota log display

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude <noreply@anthropic.com>
2025-12-09 09:44:10 -06:00
jbpratt
d04f98dbcd fix(web): use template literals for Fetch Tag pull commands (PROJQUAY-9952) (#4699)
ClipboardCopy children were passed as JSX expressions which creates an
array of React nodes. PatternFly's ClipboardCopy may join array children
with commas when extracting text, causing pull commands like:
"docker pull ,hostname,/,org,/,repo,:,tag"

Using template literals ensures a single string child is passed,
preventing the comma issue.

Co-authored-by: Claude <noreply@anthropic.com>
2025-12-09 17:29:43 +05:30
jbpratt
b0cc36b78e chore: expand pr-title-regex (#4698)
allowing the following variations:

- `test: ...`
- `test(api): ...`
- `chore: ...`
- `chore(deps): ...`

Signed-off-by: Brady Pratt <bpratt@redhat.com>
2025-12-09 02:55:26 -06:00
jbpratt
73bca47439 chore: drop mysql presubmit (#4696)
mysql support deprecation was announced in 3.6

Signed-off-by: Brady Pratt <bpratt@redhat.com>
2025-12-08 22:28:10 +00:00
Ryan Wallace
01bb1fb043 fix(quay-rosa): service account annotation level (PROJQUAY-9228) (#4697)
fix(quay-rosa): service account annotation level
2025-12-08 21:36:45 +00:00
jbpratt
63bb7af32b fix(web): show error notification on org creation failure (PROJQUAY-9948) (#4691)
Use mutateAsync instead of mutate so Promise errors propagate to the
calling code. Previously, mutate() was fire-and-forget, causing success
notifications even when the API returned 400 errors.

Remove duplicate alert notification - error is shown inline in the modal.

Co-authored-by: Claude <noreply@anthropic.com>
2025-12-08 16:58:35 +05:30
jbpratt
f4957e3e29 chore: remove deprecated reCAPTCHA support (#4690)
Remove reCAPTCHA integration from the password recovery flow
as the feature has been deprecated.

Changes:
- Delete ReCaptcha component
- Remove recaptcha token handling from Signin page
- Simplify UsePasswordRecovery hook
- Remove react-google-recaptcha dependencies
- Clean up test fixtures and CSS

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Signed-off-by: Brady Pratt <bpratt@redhat.com>
Co-authored-by: Claude <noreply@anthropic.com>
2025-12-05 08:10:43 -06:00
Kenny Lee Sin Cheong
5cbdf7ba3c metrics: add support for flask request buckets (PROJQUAY-9853) (#4638)
* metrics: add support for flask request buckets

* Add config flag to schema

* Remove unused function

* Add type annotation for config flag
2025-12-04 10:47:23 -05:00
jbpratt
a5623749f6 chore: chmod +x attachment script (#4680)
this fails otherwise

Signed-off-by: Brady Pratt <bpratt@redhat.com>
2025-12-03 14:00:28 -06:00
jbpratt
c6d948e11b fix(web): display 0.00 KiB instead of N/A for zero sizes (PROJQUAY-9860) (#4686)
The formatSize() function used a falsy check which treated 0 as invalid,
returning "N/A" instead of formatting it. Now 0 displays as "0.00 KiB"
matching the legacy UI behavior.

Signed-off-by: Brady Pratt <bpratt@redhat.com>
Co-authored-by: Claude <noreply@anthropic.com>
2025-12-03 19:44:53 +00:00
jbpratt
ed6ebc3ff6 feat(web): show password setup prompt for OIDC users in CLI config (PROJQUAY-9898) (#4681)
when using OIDC authentication and the user has no password set, display
an info alert with a "Set password" button to guide users through setting
up their CLI password

Signed-off-by: Brady Pratt <bpratt@redhat.com>
Co-authored-by: Claude <noreply@anthropic.com>
2025-12-03 19:05:24 +00:00