mirror of
https://github.com/goharbor/harbor.git
synced 2026-10-23 10:08:57 +03:00
- Added `do_validate_proxy_cache_filter` in `test_proxy_cache.py` to verify API pattern validation, doublestar, and regex filtering. - Added `Test Case - Proxy Cache Filter` in `Schedule.robot` to verify the end-to-end configuration and pull restrictions via portal. - Ensured container image cache is properly pruned before pulling to prevent false-positive cache hits. Signed-off-by: fiona-xie <fei-fx.xie@broadcom.com>
327 lines
14 KiB
Python
327 lines
14 KiB
Python
from __future__ import absolute_import
|
|
|
|
|
|
import unittest
|
|
import urllib
|
|
import sys
|
|
import os
|
|
|
|
import subprocess
|
|
|
|
from testutils import ADMIN_CLIENT, suppress_urllib3_warning, DOCKER_USER, DOCKER_PWD, JFROG_USER, JFROG_PWD, JFROG_URL, JFROG_NAMESPACE
|
|
from testutils import harbor_server
|
|
from testutils import TEARDOWN
|
|
from library.base import _random_name
|
|
from library.base import _assert_status_code
|
|
from library.project import Project
|
|
from library.user import User
|
|
from library.repository import Repository
|
|
from library.registry import Registry
|
|
from library.repository import pull_harbor_image
|
|
from library.artifact import Artifact
|
|
import library.containerd
|
|
|
|
class TestProxyCache(unittest.TestCase):
|
|
@suppress_urllib3_warning
|
|
def setUp(self):
|
|
self.url = ADMIN_CLIENT["endpoint"]
|
|
self.user_password = "Aa123456"
|
|
self.project= Project()
|
|
self.user= User()
|
|
self.repo= Repository()
|
|
self.registry = Registry()
|
|
self.artifact = Artifact()
|
|
|
|
@unittest.skipIf(TEARDOWN == False, "Test data won't be erased.")
|
|
def tearDown(self):
|
|
print("Case completed")
|
|
|
|
def do_validate(self, registry_type):
|
|
"""
|
|
Test case:
|
|
Proxy Cache Image From Harbor
|
|
Test step and expected result:
|
|
1. Create a new registry;
|
|
2. Create a new project;
|
|
3. Add a new user as a member of project;
|
|
4. Pull image from this project by docker CLI;
|
|
5. Pull image from this project by ctr CLI;
|
|
6. Pull manifest index from this project by docker CLI;
|
|
7. Pull image (multi-arch tag) from this project by ctr CLI;
|
|
8. Image pulled by docker CLI should be cached;
|
|
9. Image pulled by ctr CLI should be cached;
|
|
10. Manifest index pulled by docker CLI should be cached;
|
|
11. Image pulled by ctr CLI should be cached (ctr may cache a single-platform manifest, not a manifest list);
|
|
Tear down:
|
|
1. Delete project(PA);
|
|
2. Delete user(UA).
|
|
"""
|
|
subprocess.run(["docker", "image", "prune", "-a", "-f"], check=False)
|
|
subprocess.run(["ctr", "images", "prune", "--all"], check=False)
|
|
|
|
user_id, user_name = self.user.create_user(user_password = self.user_password, **ADMIN_CLIENT)
|
|
USER_CLIENT=dict(endpoint = self.url, username = user_name, password = self.user_password)
|
|
|
|
image_for_docker = dict(image = "for_proxy", tag = "1.0")
|
|
image_for_ctr = dict(image = "redis", tag = "latest")
|
|
index_for_docker = dict(image = "index", tag = "index_tag")
|
|
access_key = ""
|
|
access_secret = ""
|
|
|
|
#1. Create a new registry;
|
|
if registry_type == "docker-hub":
|
|
user_namespace = DOCKER_USER
|
|
access_key = DOCKER_USER
|
|
access_secret = DOCKER_PWD
|
|
registry = "https://hub.docker.com"
|
|
# Memo: ctr will not send image pull request if manifest list already exist, so we pull different manifest list for different registry;
|
|
index_for_ctr = dict(image = "alpine", tag = "3.12.0")
|
|
elif registry_type == "jfrog-artifactory":
|
|
if not (JFROG_URL and JFROG_USER and JFROG_PWD and JFROG_NAMESPACE):
|
|
self.fail(
|
|
"JFrog proxy cache test requires JFROG_URL, JFROG_USER, JFROG_PWD, and "
|
|
"JFROG_NAMESPACE. Pass them to Robot (-v JFROG_USER:... -v JFROG_PWD:... ...) or "
|
|
"set the same names in the process environment; Harbor API Test forwards them to "
|
|
"the Python API tests."
|
|
)
|
|
user_namespace = JFROG_NAMESPACE
|
|
access_key = JFROG_USER
|
|
access_secret = JFROG_PWD
|
|
registry = JFROG_URL
|
|
index_for_ctr = dict(image = "busybox", tag = "1.32.0")
|
|
else:
|
|
user_namespace = "nightly"
|
|
registry = "https://registry.goharbor.io"
|
|
index_for_ctr = dict(image = "busybox", tag = "1.32.0")
|
|
|
|
registry_payload = {
|
|
"url": registry,
|
|
"name": _random_name(registry_type),
|
|
"registry_type": registry_type,
|
|
"access_key": access_key,
|
|
"access_secret": access_secret,
|
|
"insecure": True,
|
|
}
|
|
registry_id, _ = self.registry.create_registry(
|
|
registry_payload["url"],
|
|
name=registry_payload["name"],
|
|
registry_type=registry_payload["registry_type"],
|
|
access_key=registry_payload["access_key"],
|
|
access_secret=registry_payload["access_secret"],
|
|
insecure=registry_payload["insecure"],
|
|
**ADMIN_CLIENT
|
|
)
|
|
|
|
print("registry_id:", registry_id)
|
|
|
|
#2. Create a new project;
|
|
project_id, project_name = self.project.create_project(registry_id = registry_id, metadata = {"public": "false"}, **ADMIN_CLIENT)
|
|
print("project_id:",project_id)
|
|
print("project_name:",project_name)
|
|
|
|
#3. Add a new user as a member of project;
|
|
self.project.add_project_members(project_id, user_id=user_id, **ADMIN_CLIENT)
|
|
|
|
#4. Pull image from this project by docker CLI;
|
|
pull_harbor_image(harbor_server, USER_CLIENT["username"], USER_CLIENT["password"], project_name + "/" + user_namespace + "/" + image_for_docker["image"], image_for_docker["tag"])
|
|
|
|
#5. Pull image from this project by ctr CLI;
|
|
oci_ref = harbor_server + "/" + project_name + "/" + user_namespace + "/" + image_for_ctr["image"] + ":" + image_for_ctr["tag"]
|
|
library.containerd.ctr_images_pull(user_name, self.user_password, oci_ref)
|
|
library.containerd.ctr_images_list(oci_ref = oci_ref)
|
|
|
|
#6. Pull manifest index from this project by docker CLI;
|
|
index_repo_name = user_namespace + "/" + index_for_docker["image"]
|
|
pull_harbor_image(harbor_server, user_name, self.user_password, project_name + "/" + index_repo_name, index_for_docker["tag"])
|
|
|
|
#7. Pull manifest from this project by ctr CLI;
|
|
index_repo_name_for_ctr = user_namespace + "/" + index_for_ctr["image"]
|
|
oci_ref = harbor_server + "/" + project_name + "/" + index_repo_name_for_ctr + ":" + index_for_ctr["tag"]
|
|
library.containerd.ctr_images_pull(user_name, self.user_password, oci_ref)
|
|
library.containerd.ctr_images_list(oci_ref = oci_ref)
|
|
|
|
#8. Image pulled by docker CLI should be cached;
|
|
self.artifact.waiting_for_reference_exist(project_name, urllib.parse.quote(user_namespace + "/" + image_for_docker["image"],'utf-8'), image_for_docker["tag"], **USER_CLIENT)
|
|
|
|
#9. Image pulled by ctr CLI should be cached;
|
|
self.artifact.waiting_for_reference_exist(project_name, urllib.parse.quote(user_namespace + "/" + image_for_ctr["image"],'utf-8'), image_for_ctr["tag"], **USER_CLIENT)
|
|
|
|
#10. Manifest index pulled by docker CLI should be cached;
|
|
ret_index_by_d = self.artifact.waiting_for_reference_exist(project_name, urllib.parse.quote(index_repo_name,'utf-8'), index_for_docker["tag"], **USER_CLIENT)
|
|
print("Index's reference by docker CLI:", ret_index_by_d.references)
|
|
self.assertTrue(len(ret_index_by_d.references) == 1)
|
|
|
|
#11. Manifest index pulled by ctr CLI should be cached;
|
|
ret_index_by_c = self.artifact.waiting_for_reference_exist(project_name, urllib.parse.quote(index_repo_name_for_ctr,'utf-8'), index_for_ctr["tag"], **USER_CLIENT)
|
|
print("Index's reference by ctr CLI:", ret_index_by_c.references)
|
|
self.assertTrue(len(ret_index_by_c.references) == 1)
|
|
|
|
def do_validate_proxy_cache_filter(self, registry_type="harbor"):
|
|
"""
|
|
Test case:
|
|
Proxy Cache Repository Filter
|
|
Test steps:
|
|
1. Create a registry endpoint;
|
|
2. Verify API pattern validation (400 Bad Request for
|
|
invalid regex when kind='regex');
|
|
3. Create a Proxy Cache Project with doublestar filter pattern;
|
|
4. Pull matching image -> Should succeed and be cached;
|
|
5. Pull non-matching image -> Should fail (filtered before proxy);
|
|
6. Update project metadata to regex filter pattern;
|
|
7. Pull image matching regex -> Should succeed;
|
|
8. Pull image not matching regex -> Should fail.
|
|
"""
|
|
subprocess.run(["docker", "image", "prune", "-a", "-f"], check=False)
|
|
subprocess.run(["ctr", "images", "prune", "--all"], check=False)
|
|
|
|
user_id, user_name = self.user.create_user(
|
|
user_password=self.user_password, **ADMIN_CLIENT
|
|
)
|
|
USER_CLIENT = dict(
|
|
endpoint=self.url,
|
|
username=user_name,
|
|
password=self.user_password
|
|
)
|
|
|
|
if registry_type == "docker-hub":
|
|
user_namespace = DOCKER_USER
|
|
access_key = DOCKER_USER
|
|
access_secret = DOCKER_PWD
|
|
registry = "https://hub.docker.com"
|
|
else:
|
|
user_namespace = "nightly"
|
|
registry = "https://registry.goharbor.io"
|
|
access_key = ""
|
|
access_secret = ""
|
|
|
|
registry_payload = {
|
|
"url": registry,
|
|
"name": _random_name(registry_type + "_filter"),
|
|
"registry_type": registry_type,
|
|
"access_key": access_key,
|
|
"access_secret": access_secret,
|
|
"insecure": True,
|
|
}
|
|
registry_id, _ = self.registry.create_registry(
|
|
registry_payload["url"],
|
|
name=registry_payload["name"],
|
|
registry_type=registry_payload["registry_type"],
|
|
access_key=registry_payload["access_key"],
|
|
access_secret=registry_payload["access_secret"],
|
|
insecure=registry_payload["insecure"],
|
|
**ADMIN_CLIENT
|
|
)
|
|
|
|
# 1. Test pattern validation API error (400 Bad Request)
|
|
invalid_metadata = {
|
|
"public": "false",
|
|
"proxy_cache_filter_pattern": "nightly/(*",
|
|
"proxy_cache_filter_kind": "regex",
|
|
}
|
|
self.project.create_project(
|
|
registry_id=registry_id,
|
|
metadata=invalid_metadata,
|
|
expect_status_code=400,
|
|
**ADMIN_CLIENT
|
|
)
|
|
|
|
# 2. Create Proxy Cache Project with doublestar filter pattern
|
|
allowed_image = "for_proxy"
|
|
blocked_image = "redis"
|
|
doublestar_pattern = user_namespace + "/" + allowed_image
|
|
valid_metadata = {
|
|
"public": "false",
|
|
"proxy_cache_filter_pattern": doublestar_pattern,
|
|
"proxy_cache_filter_kind": "doublestar",
|
|
}
|
|
project_id, project_name = self.project.create_project(
|
|
registry_id=registry_id,
|
|
metadata=valid_metadata,
|
|
**ADMIN_CLIENT
|
|
)
|
|
self.project.add_project_members(
|
|
project_id, user_id=user_id, **ADMIN_CLIENT
|
|
)
|
|
|
|
# 3. Pull matching image -> Should succeed
|
|
pull_harbor_image(
|
|
harbor_server,
|
|
USER_CLIENT["username"],
|
|
USER_CLIENT["password"],
|
|
project_name + "/" + user_namespace + "/" + allowed_image,
|
|
"1.0"
|
|
)
|
|
self.artifact.waiting_for_reference_exist(
|
|
project_name,
|
|
urllib.parse.quote(user_namespace + "/" + allowed_image, 'utf-8'),
|
|
"1.0",
|
|
**USER_CLIENT
|
|
)
|
|
|
|
# 4. Pull non-matching image -> Should fail (404 / manifest unknown)
|
|
pull_harbor_image(
|
|
harbor_server,
|
|
USER_CLIENT["username"],
|
|
USER_CLIENT["password"],
|
|
project_name + "/" + user_namespace + "/" + blocked_image,
|
|
"latest",
|
|
expected_error_message="repository filter"
|
|
)
|
|
|
|
# 5. Update project metadata to regex filter pattern
|
|
regex_pattern = r"^" + user_namespace + r"/(for_proxy|redis)$"
|
|
updated_metadata = {
|
|
"proxy_cache_filter_pattern": regex_pattern,
|
|
"proxy_cache_filter_kind": "regex",
|
|
}
|
|
self.project.update_project(
|
|
project_id, metadata=updated_metadata, **ADMIN_CLIENT
|
|
)
|
|
|
|
# 6. Pull newly allowed image -> Should succeed now
|
|
pull_harbor_image(
|
|
harbor_server,
|
|
USER_CLIENT["username"],
|
|
USER_CLIENT["password"],
|
|
project_name + "/" + user_namespace + "/" + blocked_image,
|
|
"latest"
|
|
)
|
|
self.artifact.waiting_for_reference_exist(
|
|
project_name,
|
|
urllib.parse.quote(
|
|
user_namespace + "/" + blocked_image, 'utf-8'
|
|
),
|
|
"latest",
|
|
**USER_CLIENT
|
|
)
|
|
|
|
# 7. Pull image not matching regex -> Should fail
|
|
pull_harbor_image(
|
|
harbor_server,
|
|
USER_CLIENT["username"],
|
|
USER_CLIENT["password"],
|
|
project_name + "/" + user_namespace + "/busybox",
|
|
"latest",
|
|
expected_error_message="repository filter"
|
|
)
|
|
|
|
def test_proxy_cache(self):
|
|
proxy_upstream_list = os.getenv("PROXY_UPSTREAM_LIST", "").lower()
|
|
if not proxy_upstream_list or "harbor" in proxy_upstream_list:
|
|
self.do_validate("harbor")
|
|
self.do_validate_proxy_cache_filter("harbor")
|
|
if "docker-hub" in proxy_upstream_list:
|
|
self.do_validate("docker-hub")
|
|
self.do_validate_proxy_cache_filter("docker-hub")
|
|
if "jfrog" in proxy_upstream_list:
|
|
self.do_validate("jfrog-artifactory")
|
|
|
|
|
|
if __name__ == '__main__':
|
|
suite = unittest.TestSuite(unittest.makeSuite(TestProxyCache))
|
|
result = unittest.TextTestRunner(
|
|
sys.stdout, verbosity=2, failfast=True
|
|
).run(suite)
|
|
if not result.wasSuccessful():
|
|
raise Exception("Proxy cache test failed: {}".format(result))
|