Merge pull request #169 from vieux/create_fct_remove

remove useless create fct

discovery/discovery.go

@@ -34,21 +34,21 @@ type DiscoveryService interface {
 }
 
 var (
-	discoveries       map[string]func() DiscoveryService
+	discoveries       map[string]DiscoveryService
 	ErrNotSupported   = errors.New("discovery service not supported")
 	ErrNotImplemented = errors.New("not implemented in this discovery service")
 )
 
 func init() {
-	discoveries = make(map[string]func() DiscoveryService)
+	discoveries = make(map[string]DiscoveryService)
 }
 
-func Register(scheme string, f func() DiscoveryService) error {
+func Register(scheme string, d DiscoveryService) error {
 	if _, exists := discoveries[scheme]; exists {
 		return fmt.Errorf("scheme already registered %s", scheme)
 	}
 	log.Debugf("Registering %q discovery service", scheme)
-	discoveries[scheme] = f
+	discoveries[scheme] = d
 
 	return nil
 }
@@ -59,9 +59,8 @@ func New(rawurl string, heartbeat int) (DiscoveryService, error) {
 		return nil, err
 	}
 
-	if f, exists := discoveries[url.Scheme]; exists {
+	if discovery, exists := discoveries[url.Scheme]; exists {
 		log.Debugf("Initialising %q discovery service with %q", url.Scheme, url.Host+url.Path)
-		discovery := f()
 		err := discovery.Initialize(url.Host+url.Path, heartbeat)
 		return discovery, err
 	}

discovery/etcd/etcd.go

@@ -16,11 +16,7 @@ type EtcdDiscoveryService struct {
 }
 
 func init() {
-	discovery.Register("etcd",
-		func() discovery.DiscoveryService {
-			return &EtcdDiscoveryService{}
-		},
-	)
+	discovery.Register("etcd", &EtcdDiscoveryService{})
 }
 
 func (s *EtcdDiscoveryService) Initialize(uris string, heartbeat int) error {

discovery/file/file.go

@@ -14,11 +14,7 @@ type FileDiscoveryService struct {
 }
 
 func init() {
-	discovery.Register("file",
-		func() discovery.DiscoveryService {
-			return &FileDiscoveryService{}
-		},
-	)
+	discovery.Register("file", &FileDiscoveryService{})
 }
 
 func (s *FileDiscoveryService) Initialize(path string, heartbeat int) error {

discovery/token/token.go

@@ -20,11 +20,7 @@ type TokenDiscoveryService struct {
 }
 
 func init() {
-	discovery.Register("token",
-		func() discovery.DiscoveryService {
-			return &TokenDiscoveryService{}
-		},
-	)
+	discovery.Register("token", &TokenDiscoveryService{})
 }
 
 func (s *TokenDiscoveryService) Initialize(urltoken string, heartbeat int) error {