mirror of
https://github.com/docker/cli.git
synced 2026-01-13 18:22:35 +03:00
02b6af2e96
Since systemd version 228, a new setting, `TasksMax`, has appeared, which limits the number of tasks used by a service (via pids cgroup controller). Unfortunately, a default for this setting, `DefaultTaskMax`, is set to 512. In systemd version 231 it is changed to 15% which practically is 4195, as the value from /proc/sys/kernel/pid_max is treated like 100%). Either 512 or 4195 is severily limited value for Docker Engine, as it can run thousands of containers with thousands of tasks in each, and the number of tasks limit should be set on a per-container basis by the Docker user. So, the most reasonable setting for `TasksMax` is `unlimited`. Unfortunately, older versions of systemd warn about unknown `TasksMax` parameter in `docker.service` file, and the warning is rather annoying, therefore this setting is commented out by default, and is supposed to be uncommented by the user. The problem with that is, once the limit is hit, all sorts of bad things happen and it's not really clear even to an advanced user that this setting is the source of issues. As Fedora 25 ships systemd 231, it (and later Fedora releases) support TasksMax, so it makes total sense to uncomment the setting, this is what this commit does. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> Upstream-commit: 9055832bb0725f05d518c3ebc9b7cc93a69420c7 Component: packaging