docker/cli
1
0
Fork 0
mirror of https://github.com/docker/cli.git synced 2026-01-13 18:22:35 +03:00
Code Activity
6,498 Commits 12 Branches 295 Tags
c828fa141d06c8add64959440d16c85f8dfb0c7e
Commit Graph

6498 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Sebastiaan van Stijn
c828fa141d service/logs: Using the variable on range scope testcase in function literal (scopelint) 
```
service/logs/parse_logs_test.go:26:35: Using the variable on range scope `testcase` in function literal (scopelint)
			actual, err := ParseLogDetails(testcase.line)
			                               ^
service/logs/parse_logs_test.go:27:7: Using the variable on range scope `testcase` in function literal (scopelint)
			if testcase.err != nil {
			   ^
service/logs/parse_logs_test.go:28:26: Using the variable on range scope `testcase` in function literal (scopelint)
				assert.Error(t, err, testcase.err.Error())
				                     ^
```

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2019-10-31 19:22:33 +01:00
Sebastiaan van Stijn
5a2a9d9ca8 cli/config: Using the variable on range scope tc in function literal (scopelint) 
```
cli/config/config_test.go:590:11: Using the variable on range scope `tc` in function literal (scopelint)
			SetDir(tc.dir)
			       ^
cli/config/config_test.go:591:19: Using the variable on range scope `tc` in function literal (scopelint)
			f, err := Path(tc.path...)
			               ^
cli/config/config_test.go:592:23: Using the variable on range scope `tc` in function literal (scopelint)
			assert.Equal(t, f, tc.expected)
			                   ^
```

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2019-10-31 19:22:32 +01:00
Sebastiaan van Stijn
e74e2c7741 cli/command/formatter: Error return value of ContainerWrite is not checked (errcheck) 
```
cli/command/formatter/container_test.go:315:17: Error return value of `ContainerWrite` is not checked (errcheck)
		ContainerWrite(context.context, containers)
		              ^
```

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2019-10-31 19:22:31 +01:00
Sebastiaan van Stijn
008f6a2da3 cli/command: Error return value of cli.Apply is not checked (errcheck) 
```
cli/command/cli_test.go:297:11: Error return value of `cli.Apply` is not checked (errcheck)
	cli.Apply(
	         ^
```

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2019-10-31 19:22:31 +01:00
Sebastiaan van Stijn
9275e2cb66 cli/command/formatter: Error return value of ImageWrite is not checked (errcheck) 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2019-10-31 19:22:30 +01:00
Sebastiaan van Stijn
fe3cc6eb7b cli/context/store: SA5001: should check returned error before deferring f.Close() (staticcheck) 
```
cli/context/store/store_test.go:156:2: SA5001: should check returned error before deferring f.Close() (staticcheck)
	defer f.Close()
	^
cli/context/store/store_test.go:189:2: SA5001: should check returned error before deferring f.Close() (staticcheck)
	defer f.Close()
	^
cli/context/store/store_test.go:240:2: SA5001: should check returned error before deferring f.Close() (staticcheck)
	defer f.Close()
	^
```

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2019-10-31 19:22:30 +01:00
Sebastiaan van Stijn
709728e723 cli/command/image: SA1006: printf-style with no further arguments (staticcheck) 
cli/command/image/build.go:434:32: SA1006: printf-style function with dynamic format string and no further arguments should use print-style function instead (staticcheck)
    		fmt.Fprintf(dockerCli.Out(), imageID)
    		                             ^

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2019-10-31 19:22:29 +01:00
Sebastiaan van Stijn
ea64a1ceb9 cli/command/utils: SA1006: printf-style with no further arguments (staticcheck) 
```
cli/command/utils.go:81:20: SA1006: printf-style function with dynamic format string and no further arguments should use print-style function instead (staticcheck)
	fmt.Fprintf(outs, message)
	                  ^
```

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2019-10-31 19:22:29 +01:00
Sebastiaan van Stijn
f0614ca788 cli/command/trust: SA1006: printf-style with no further arguments (staticcheck) 
```
cli/command/trust/key_generate.go:91:30: SA1006: printf-style function with dynamic format string and no further arguments should use print-style function instead (staticcheck)
		fmt.Fprintf(streams.Out(), err.Error())
		                           ^
```

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2019-10-31 19:22:28 +01:00
Sebastiaan van Stijn
0e4bd30cfe cli/command/image/build: G107: Potential HTTP request made with variable url (gosec) 
cli/command/image/build/context.go:235: G107: Potential HTTP request made with variable url (gosec)
    	if resp, err = http.Get(url); err != nil {

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2019-10-31 19:22:28 +01:00
Sebastiaan van Stijn
8d64c2af1a cli/command/service: SA1012: do not pass a nil Context (staticcheck) 
```
cli/command/service/update_test.go:31:16: SA1012: do not pass a nil Context, even if a function permits it; pass context.TODO if you are unsure about which Context to use (staticcheck)
	updateService(nil, nil, flags, spec)
	              ^
cli/command/service/update_test.go:535:16: SA1012: do not pass a nil Context, even if a function permits it; pass context.TODO if you are unsure about which Context to use (staticcheck)
	updateService(nil, nil, flags, spec)
	              ^
cli/command/service/update_test.go:540:16: SA1012: do not pass a nil Context, even if a function permits it; pass context.TODO if you are unsure about which Context to use (staticcheck)
	updateService(nil, nil, flags, spec)
	              ^
```

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2019-10-31 19:22:27 +01:00
Sebastiaan van Stijn
1850a0595b cli/command/secret: G101: Potential hardcoded credentials (gosec) 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2019-10-31 19:22:27 +01:00
Sebastiaan van Stijn
34f595975d cli/compose/convert: driverObjectConfig - result 1 (error) is always nil (unparam) 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2019-10-31 19:22:26 +01:00
Sebastiaan van Stijn
6205ef33be e2e/container: containerExistsWithStatus - t is unused (unparam) 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2019-10-31 19:22:26 +01:00
Silvin Lubecki
b83545ebbc cli/command/image/build/context_test.go:244:38: createTestTempDir - prefix always receives "builder-context-test" (unparam) 
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
 2019-10-31 19:22:25 +01:00
Silvin Lubecki
4be924a0af cli/command/registry/login_test.go:66:25: unnecessary conversion (unconvert) 
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
 2019-10-31 19:22:25 +01:00
Silvin Lubecki
c237379167 cli/compose/convert/service_test.go:274:72: unnecessary conversion (unconvert) 
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
 2019-10-31 19:22:24 +01:00
Silvin Lubecki
6047259e5a File is not goimports-ed (goimports) 
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
 2019-10-31 19:22:24 +01:00
Silvin Lubecki
0153624a56 cli/command/trust/sign_test.go:119:70: unnecessary conversion (unconvert) 
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
 2019-10-31 19:22:23 +01:00
Silvin Lubecki
f123e43c1f Disable unparam linter: e2e/image/push_test.go:299:27: withNotaryPassphrase - pwd always receives "foo" (unparam) 
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
 2019-10-31 19:22:23 +01:00
Silvin Lubecki
7d823438bb Disable unparam linter: cli/required.go:102:16: pluralize - word always receives "argument" (unparam) 
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
 2019-10-31 19:22:22 +01:00
Sebastiaan van Stijn
9118b2b2b8 compose/loader: define type for transformer-functions 
Also explicitly type transformer-functions

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2019-10-31 19:22:21 +01:00
Silvin Lubecki
6eb0c9c613 disable unparam linter on these functions, as we need an error in these function signatures 
cli/compose/loader/loader.go:756:66: transformServiceNetworkMap - result 1 (error) is always nil (unparam)
cli/compose/loader/loader.go:767:67: transformStringOrNumberList - result 1 (error) is always nil (unparam)

Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2019-10-31 19:22:21 +01:00
Silvin Lubecki
d640f44df3 cli/compose/convert: result 1 (error) is always nil (unparam) 
cli/compose/convert/service.go:592:76: convertDNSConfig - result 1 (error) is always nil (unparam)
cli/compose/convert/service.go:538:110: convertEndpointSpec - result 1 (error) is always nil (unparam)

Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2019-10-31 19:22:20 +01:00
Silvin Lubecki
47741f81d1 cli/command/system/info.go:116:68: prettyPrintClientInfo - result 0 (error) is always nil (unparam) 
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
 2019-10-31 19:22:20 +01:00
Silvin Lubecki
a3c7cb4f12 cli/command/stack/kubernetes/deploy_test.go:65:68: checkOwnerReferences - stackName always receives "test" (unparam) 
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
 2019-10-31 19:22:19 +01:00
Silvin Lubecki
ab1aeedb27 cli/command/plugin/list_test.go:61:31: TestList$1 - filter is unused (unparam) 
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
 2019-10-31 19:22:19 +01:00
Silvin Lubecki
75c60c1af7 cli/command/image/build_session.go:133:45: getBuildSharedKey - result 1 (error) is always nil (unparam) 
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
 2019-10-31 19:22:18 +01:00
Silvin Lubecki
28ac2f82c6 cli/command/image/build_buildkit.go:450:56: parseSSH - result 1 (error) is always nil (unparam) 
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
 2019-10-31 19:22:18 +01:00
Silvin Lubecki
0ce2eae5a2 cli/command/image/build/context_test.go:252:71: createTestTempFile - perm always receives 0777 (511) (unparam) 
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
 2019-10-31 19:22:17 +01:00
Silvin Lubecki
70bd64d037 cli/command/image/build/context_test.go:244:38: createTestTempDir - dir always receives "" (unparam) 
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
 2019-10-31 19:22:17 +01:00
Silvin Lubecki
e1c0c7979e unchecked errors 
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
 2019-10-31 19:22:16 +01:00
Silvin Lubecki
584da37756 cli/command/container/attach.go:141:15: nilness: impossible condition: nil != nil (govet) 
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
 2019-10-31 19:22:16 +01:00
Silvin Lubecki
b3d4c6aac7 opts/ulimit_test.go:11:13: composites: *github.com/docker/cli/vendor/github.com/docker/go-units.Ulimit composite literal uses unkeyed fields (govet) 
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
 2019-10-31 19:22:15 +01:00
Silvin Lubecki
1bfe81318d cli/compose/types/types.go:106:2: structtag: struct field tag yaml:",inline", json:"-" not compatible with reflect.StructTag.Get: key:"value" pairs not separated by spaces (govet) 
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
 2019-10-31 19:22:14 +01:00
Silvin Lubecki
5ceed3059f cli/registry/client/fetcher.go:106:9: nilness: impossible condition: nil != nil (govet) 
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
 2019-10-31 19:22:14 +01:00
Silvin Lubecki
9afeb6f432 cli/command/container/start.go:157:20: nilness: nil dereference in type assertion (govet) 
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
 2019-10-31 19:22:13 +01:00
Silvin Lubecki
85cfd4e518 cli/command/stack/kubernetes/list.go:32:47: nilness: tautological condition: non-nil != nil (govet) 
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
 2019-10-31 19:22:13 +01:00
Silvin Lubecki
f5e8387067 cli/command/trust/key_generate.go:112:9: nilness: impossible condition: nil != nil (govet) 
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
 2019-10-31 19:22:12 +01:00
Silvin Lubecki
3a428202bf SA1019: httputil.ErrPersistEOF is deprecated: No longer used. (staticcheck) 
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
 2019-10-31 19:22:12 +01:00
Silvin Lubecki
7da9360477 cli/command/container/stats.go:211:21: SA1015: using time.Tick leaks the underlying ticker, consider using it only in endless functions, tests and the main package, and use time.NewTicker here (staticcheck) 
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
 2019-10-31 19:22:11 +01:00
Silvin Lubecki
8018a850cb cli/command/trust/inspect_pretty_test.go:399:24: SA4010: this result of append is never used, except maybe in other appends (staticcheck) 
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
 2019-10-31 19:22:10 +01:00
Silvin Lubecki
296297190c opts/throttledevice.go:51:5: SA4003: unsigned values are never < 0 (staticcheck) 
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2019-10-31 19:21:55 +01:00
Sebastiaan van Stijn
ab255f13b7 Merge pull request #2180 from thaJeztah/refactor_conversion_test 
kubernetes/conversion_test: use test-builders package
 2019-10-31 19:20:36 +01:00
Sebastiaan van Stijn
2d0c10d77a kubernetes/conversion_test: use test-builders package 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2019-10-31 16:10:22 +01:00
Sebastiaan van Stijn
270defa177 internal/test/builders: don't set EndpointSpec by default 
Also rewrite `Service()` to use the available options

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
 2019-10-31 16:08:49 +01:00
Joe Abbey
1de18a9b98 Merge pull request #2140 from chris-crone/bump-compose-on-kubernetes 
Bump Compose on Kubernetes
 2019-10-30 17:22:55 -04:00
Christopher Crone
e4d3c360b2 Bump Compose on Kubernetes 
Signed-off-by: Christopher Crone <christopher.crone@docker.com>
 2019-10-30 22:08:14 +01:00
Sebastiaan van Stijn
6318939f30 Merge pull request #2167 from thaJeztah/carry_refactor_stack_services 
Refactor the `stack services` command to be uniform [carry 2131]
 2019-10-30 08:47:47 +01:00
Silvin Lubecki
01a8d2c2c4 Merge pull request #2159 from thaJeztah/bump_go_version 
bump hashicorp/go-version v1.2.0
 2019-10-29 16:27:54 +01:00