docker/cli
1
0
Fork 0
mirror of https://github.com/docker/cli.git synced 2026-01-13 18:22:35 +03:00
Code Activity

Some enhancement in integration tests

Browse Source 
This fix converts some `client.ContainerCreate` to `container.Create`,
and removes some unneeded `name` fields when test containers are created.

Signed-off-by: Yong Tang <yong.tang.github@outlook.com>
Upstream-commit: ab9bb47b05b1dde445a5e4ba78ae97303208dc8b
Component: engine
This commit is contained in:
Yong Tang
2018-04-14 16:52:02 +00:00
parent fce8015aac
commit 691aeed45e
3 changed files with 11 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
components/engine/integration/container/create_test.go
View File

@@ -46,7 +46,7 @@ func TestCreateFailsWhenIdentifierDoesNotExist(t *testing.T) {
&container.Config{Image: tc.image},
&container.HostConfig{},
&network.NetworkingConfig{},
"foo",
"",
)
testutil.ErrorContains(t, err, tc.expectedError)
})
@@ -86,7 +86,7 @@ func TestCreateWithInvalidEnv(t *testing.T) {
},
&container.HostConfig{},
&network.NetworkingConfig{},
"foo",
"",
)
testutil.ErrorContains(t, err, tc.expectedError)
})

10
components/engine/integration/container/export_test.go
View File

@@ -7,7 +7,6 @@ import (
"time"
"github.com/docker/docker/api/types"
containerTypes "github.com/docker/docker/api/types/container"
"github.com/docker/docker/api/types/filters"
"github.com/docker/docker/integration/internal/container"
"github.com/docker/docker/integration/internal/request"
@@ -70,15 +69,10 @@ func TestExportContainerAfterDaemonRestart(t *testing.T) {
defer d.Stop(t)
ctx := context.Background()
cfg := containerTypes.Config{
Image: "busybox",
Cmd: []string{"top"},
}
ctr, err := client.ContainerCreate(ctx, &cfg, nil, nil, "")
assert.NilError(t, err)
ctrID := container.Create(t, ctx, client)
d.Restart(t)
_, err = client.ContainerExport(ctx, ctr.ID)
_, err = client.ContainerExport(ctx, ctrID)
assert.NilError(t, err)
}

22
components/engine/integration/system/cgroupdriver_systemd_test.go
View File

@@ -6,7 +6,7 @@ import (
"testing"
"github.com/docker/docker/api/types"
"github.com/docker/docker/api/types/container"
"github.com/docker/docker/integration/internal/container"
"github.com/docker/docker/internal/test/daemon"
"github.com/gotestyourself/gotestyourself/assert"
@@ -40,25 +40,17 @@ func TestCgroupDriverSystemdMemoryLimit(t *testing.T) {
defer d.Stop(t)
const mem = 64 * 1024 * 1024 // 64 MB
cfg := container.Config{
Image: "busybox",
Cmd: []string{"top"},
}
hostcfg := container.HostConfig{
Resources: container.Resources{
Memory: mem,
},
}
ctx := context.Background()
ctr, err := client.ContainerCreate(ctx, &cfg, &hostcfg, nil, "")
assert.NilError(t, err)
defer client.ContainerRemove(ctx, ctr.ID, types.ContainerRemoveOptions{Force: true})
ctrID := container.Create(t, ctx, client, func(c *container.TestContainerConfig) {
c.HostConfig.Resources.Memory = mem
})
defer client.ContainerRemove(ctx, ctrID, types.ContainerRemoveOptions{Force: true})
err = client.ContainerStart(ctx, ctr.ID, types.ContainerStartOptions{})
err = client.ContainerStart(ctx, ctrID, types.ContainerStartOptions{})
assert.NilError(t, err)
s, err := client.ContainerInspect(ctx, ctr.ID)
s, err := client.ContainerInspect(ctx, ctrID)
assert.NilError(t, err)
assert.Equal(t, s.HostConfig.Memory, mem)
}