docker/buildah
docker/buildah
1
0
Fork 0
mirror of https://github.com/containers/buildah.git synced 2025-04-18 07:04:05 +03:00
Code
6,253 Commits 30 Branches 195 Tags
Commit Graph

6253 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
openshift-merge-bot[bot]
1db3b5465b
Merge pull request #6135 from containers/renovate/github.com-containers-common-0.x 
fix(deps): update module github.com/containers/common to v0.63.0
 2025-04-17 17:37:55 +00:00
Nalin Dahyabhai
365ad53dfc CI vendor_task: pin to go 1.23.3 for now 
Pin to 1.23.3 specifically instead of 1.23, for now.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
 2025-04-17 12:41:11 -04:00
renovate[bot]
522bc8ba58
fix(deps): update module github.com/containers/common to v0.63.0 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 2025-04-17 15:36:04 +00:00
openshift-merge-bot[bot]
a0945beb1e
Merge pull request #6134 from containers/renovate/github.com-docker-docker-28.x 
fix(deps): update module github.com/docker/docker to v28.1.0+incompatible
 2025-04-17 15:29:22 +00:00
renovate[bot]
a1df886a81
fix(deps): update module github.com/docker/docker to v28.1.0+incompatible 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 2025-04-17 14:26:17 +00:00
openshift-merge-bot[bot]
01d92cd614
Merge pull request #6129 from nalind/chroot-troubleshoot 
chroot: use symbolic names when complaining about mount() errors
 2025-04-17 13:51:54 +00:00
openshift-merge-bot[bot]
3a4249802e
Merge pull request #6099 from ninja-quokka/update_issue_template 
Update Buildah issue template to new version and support podman build
 2025-04-17 13:49:12 +00:00
openshift-merge-bot[bot]
01b8522d7a
Merge pull request #6127 from nalind/doc-src 
[CI:DOCS] Document rw/src for --mount in buildah-run(1)
 2025-04-17 13:45:52 +00:00
openshift-merge-bot[bot]
a9d6f2d7f8
Merge pull request #6131 from containers/renovate/github.com-containers-storage-1.x 
fix(deps): update module github.com/containers/storage to v1.58.0
 2025-04-16 17:57:35 +00:00
openshift-merge-bot[bot]
018e1915d2
Merge pull request #6130 from Luap99/cirrus-rootless 
cirrus: make Total Success wait for rootless integration
 2025-04-16 17:54:53 +00:00
renovate[bot]
aedcd3d19e
fix(deps): update module github.com/containers/storage to v1.58.0 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 2025-04-16 16:19:48 +00:00
openshift-merge-bot[bot]
352eda35bc
Merge pull request #6128 from nalind/completion 
cli: hide the `completion` command instead of disabling it outright
 2025-04-16 16:18:31 +00:00
Paul Holzinger
5789a60072
cirrus: make Total Success wait for rootless integration 
As discovered by Matt[1], without this we could merge PRs even if they
have failing rootless integration tests.

[1] https://github.com/containers/buildah/pull/6120#issuecomment-2797581476

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
 2025-04-16 18:09:30 +02:00
Nalin Dahyabhai
0da7ea1cc4 chroot: use symbolic names when complaining about mount() errors 
Translate flags passed to mount() and read back using statfs() from hex
to named constants, to make troubleshooting a bit easier.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
 2025-04-15 17:53:43 -04:00
Nalin Dahyabhai
08cc023eef cli: hide the completion command instead of disabling it outright 
Hide the cobra built-in `completion` command instead of disabling it
outright, since eventually we want to switch to using it instead of the
hand-written scripts we're currently using.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
 2025-04-15 17:28:28 -04:00
Nalin Dahyabhai
26ad103469 Document rw and src options for --mount flag in buildah-run(1) 
Per discussion item 6084.

Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
 2025-04-15 17:22:01 -04:00
openshift-merge-bot[bot]
dca9197ba1
Merge pull request #6125 from containers/renovate/github.com-moby-buildkit-0.x 
fix(deps): update module github.com/moby/buildkit to v0.21.0
 2025-04-15 19:35:33 +00:00
renovate[bot]
b85a67e5ce
fix(deps): update module github.com/moby/buildkit to v0.21.0 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 2025-04-15 17:24:09 +00:00
openshift-merge-bot[bot]
9a82bcc989
Merge pull request #6103 from flouthoc/inherit-labels 
build: add support for `--inherit-labels`
 2025-04-15 17:15:12 +00:00
Aditya R
a235033662
build: add support for inherit-labels 
Allows users to specify if they want to inherit labels from base image
or not.

Signed-off-by: flouthoc <flouthoc.git@gmail.com>
 2025-04-14 14:01:00 -07:00
openshift-merge-bot[bot]
ebbfb3ab13
Merge pull request #6122 from containers/renovate/golangci-golangci-lint-2.x 
chore(deps): update dependency golangci/golangci-lint to v2.1.0
 2025-04-14 14:08:47 +00:00
renovate[bot]
d2e334df97
chore(deps): update dependency golangci/golangci-lint to v2.1.0 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 2025-04-12 18:13:55 +00:00
openshift-merge-bot[bot]
0db475592c
Merge pull request #6120 from Luap99/github 
.github: check_cirrus_cron work around github bug
 2025-04-11 17:30:22 +00:00
Paul Holzinger
e6a7608219
.github: check_cirrus_cron work around github bug 
So I wondered why our email workflow only reported things for podman...

It seems the secrets: inherit is broken and no longer working, I see all
jobs on all repos failing with:

Error when evaluating 'secrets'. .github/workflows/check_cirrus_cron.yml (Line: 19, Col: 11): Secret SECRET_CIRRUS_API_KEY is required, but not provided while calling.

This makes no sense to me I doubled checked the names, nothing changed
on our side and it is consistent for all projects. Interestingly this
same thing passed on March 10 and 11 (on all repos) but failed before
and after this as well.

Per[1] we are not alone, anyway let's try to get this working again even
if it means more duplication.

[1] actions/runner#2709

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
 2025-04-11 18:59:18 +02:00
openshift-merge-bot[bot]
025e3e572f
Merge pull request #6110 from flouthoc/expand-mount-source 
stage_executor,getCreatedBy: expand buildArgs before invoking `generatePathChecksum`
 2025-04-10 17:34:59 +00:00
flouthoc
bc05858e50
stage_executor,getCreatedBy: expand buildArgs for sources correctly 
Patch in PR https://github.com/containers/buildah/pull/5691 added a
function to calculate and write checksum to history of `source` in
`--mount` instructions but it did not add part to expand build args if
they are present in `source` path.

Following PR Just corrects the above issue and also adds a new test to
make sure we don't break this in future again.

Closes: https://github.com/containers/podman/issues/25425

Signed-off-by: flouthoc <flouthoc.git@gmail.com>
 2025-04-10 10:02:56 -07:00
openshift-merge-bot[bot]
2de361a69a
Merge pull request #6108 from mheon/add_governance_and_owners 
Add a link to project governance and MAINTAINERS file
 2025-04-10 15:11:16 +00:00
Matt Heon
53cd313e10 Add a link to project governance and MAINTAINERS file 
The MAINTAINERS file is based on the current OWNERS file. I added
our core maintainers as they are expected to have commit bits on
all project repositories.

The existing MAINTAINERS file, which appears out of date, was
removed in favor of the new one (which has all CNCF mandated
information).

Signed-off-by: Matt Heon <mheon@redhat.com>
 2025-04-10 10:39:49 -04:00
openshift-merge-bot[bot]
5367a714f2
Merge pull request #6118 from kolyshkin/modernize 
Modernize
 2025-04-10 10:04:57 +00:00
openshift-merge-bot[bot]
47b3b1e783
Merge pull request #6100 from containers/renovate/github.com-containers-storage-digest 
fix(deps): update github.com/containers/storage digest to b1d1b45
 2025-04-09 21:57:59 +00:00
renovate[bot]
d753211f60
fix(deps): update github.com/containers/storage digest to b1d1b45 
Signed-off-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
 2025-04-09 20:15:23 +00:00
Kir Kolyshkin
608e4cc24f generateHostname: simplify 
No functionality change, just code simplification.

Covered by existing test (e.g. "run should also override /etc/hostname"
in tests/run.bats).

NO NEW TESTS NEEDED

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
 2025-04-08 15:26:09 -07:00
Kir Kolyshkin
f261d6641c Use maps.Copy 
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
 2025-04-08 15:26:09 -07:00
Kir Kolyshkin
76e58eea14 Use slices.Concat 
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
 2025-04-08 15:26:09 -07:00
Kir Kolyshkin
0835cb4760 Use slices.Clone 
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
 2025-04-08 15:26:09 -07:00
Kir Kolyshkin
84a3905f61 Use slices.Contains 
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
 2025-04-08 15:26:01 -07:00
Kir Kolyshkin
17777cf8ac Use for range over integers 
Available since Go 1.22 (see https://tip.golang.org/ref/spec#For_range).

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
 2025-04-08 10:19:51 -07:00
Kir Kolyshkin
c46bbf46af tests/testreport: don't copy os.Environ 
A slice returned by os.Environ is a already a brand new copy, no need to
copy it again.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
 2025-04-08 10:19:51 -07:00
Kir Kolyshkin
1ede7ddce7 Use any instead of interface{} 
Brought to you by

	gofmt -r 'interface{} -> any' -w .

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
 2025-04-08 10:19:51 -07:00
openshift-merge-bot[bot]
bb240a6e40
Merge pull request #6109 from kolyshkin/golangci-v2 
Golangci v2
 2025-04-08 15:36:10 +00:00
openshift-merge-bot[bot]
f42c70ea3a
Merge pull request #6117 from containers/renovate/github.com-containernetworking-cni-1.x 
fix(deps): update module github.com/containernetworking/cni to v1.3.0
 2025-04-07 21:59:58 +00:00
Kir Kolyshkin
d9978eb2fa ci: add golangci-lint run with --tests=false 
This helps to find out code which is unused except in its own self
tests. For example, see PR 6101.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
 2025-04-07 13:02:39 -07:00
Kir Kolyshkin
e8dba98314 ci: add nolintlint, fix found issues 
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
 2025-04-07 13:02:39 -07:00
Kir Kolyshkin
2162b3c93a copier: rm nolint:unparam annotation 
This function always returns nil as the first parameter, which makes
unparam linter sad.

Rather than adding //nolint:unparam, let's just move nil to actual
returns.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
 2025-04-07 13:02:34 -07:00
Kir Kolyshkin
757175d2e6 .golangci.yml: add unused linter 
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
 2025-04-07 13:01:56 -07:00
Kir Kolyshkin
4249d94d76 chroot: fix unused warnings 
When running golangci-lint run --tests=false, it complains:

> chroot/seccomp.go:15:7: const `seccompAvailable` is unused (unused)
> const seccompAvailable = true
>       ^
> chroot/seccomp.go:182:6: func `setupSeccomp` is unused (unused)
> func setupSeccomp(spec *specs.Spec, seccompProfilePath string) error {
>      ^

Fix this.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
 2025-04-07 13:01:56 -07:00
Kir Kolyshkin
e548eaf146 copier: fix unused warnings 
Found when running golangci-lint with --tests=false, which results in:

> copier/syscall_unix.go:89:2: const `testModeMask` is unused (unused)
> 	testModeMask           = int64(os.ModePerm)
> 	^
> copier/syscall_unix.go:90:2: const `testIgnoreSymlinkDates` is unused (unused)
> 	testIgnoreSymlinkDates = false
> 	^

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
 2025-04-07 13:01:56 -07:00
Kir Kolyshkin
8b3c045638 tests/conformance: fix unused warning 
There is some code in tests/conformance which is only used by tests.
Move it to *_test.go files.

Found by golangci-lint run --tests=false, which shows this warning:

> tests/conformance/selinux.go:9:6: func `selinuxMountFlag` is unused (unused)
> func selinuxMountFlag() string {
>      ^

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
 2025-04-07 13:01:56 -07:00
Kir Kolyshkin
e8a5d77b09 ci: switch to golangci-lint v2 
Also, add a way to update golangci-lint locally, if an old version is
installed.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
 2025-04-07 13:01:56 -07:00
Kir Kolyshkin
195c6b0c9e internal/mkcw: disable ST1003 warnings 
Disable warnings like this one:

> internal/mkcw/workload.go:34:2: ST1003: should not use ALL_CAPS in Go names; use CamelCase instead (staticcheck)
> 	SEV_NO_ES = types.SEV_NO_ES //revive:disable-line:var-naming
> 	^

(

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
 2025-04-07 13:01:56 -07:00