mirror of
https://github.com/facebook/rocksdb.git
synced 2026-10-23 08:09:02 +03:00
f9f408f536
Summary: Start the process of migrating the HCC implementation over to my new system of "bit field atomics" to clean up the code. Here I took on the simplest of the three "bit field atomic" formats in HCC, but ended up moving some things around to end up with less plumbing of definitions and values overall. In the process, updated BitFields to use the CRTP pattern to simplify some things (see updated example, etc.) https://en.wikipedia.org/wiki/Curiously_recurring_template_pattern Pull Request resolved: https://github.com/facebook/rocksdb/pull/13965 Test Plan: existing tests. ClockCacheTest.ClockEvictionEffortCapTest caught a regression during my development, and the crash test has a history of finding subtle HCC bugs. Reviewed By: xingbowang Differential Revision: D82669582 Pulled By: pdillinger fbshipit-source-id: b73dd47361cbe9fbd334413dd4ce01b3c667159e