74aba599ab
Summary: Pull Request resolved: https://github.com/facebook/rocksdb/pull/14920 When a WriteUnprepared transaction's commit write fails while two_write_queues is enabled (e.g. due to an I/O error), CommitInternal() unconditionally cleared unprep_seqs_ and the flushed/unflushed save points before returning the error. That left the transaction with no record of its prepared sequence numbers, so a subsequent Rollback() -- the natural way for a caller to recover from a failed commit -- constructed a WriteUnpreparedCommitEntryPreReleaseCallback over an empty unprep_seqs_ and tripped assert(unprep_seqs.size() > 0) in its constructor. In release builds this would instead corrupt commit-cache accounting rather than aborting. Fix: only clear unprep_seqs_ and the save points on the commit success path. On the two-write-queues commit-write failure path we still remove the prepared entry that AddPreparedCallback may have added for commit_batch_seq (that seq is never stored in unprep_seqs_, so a later Rollback cannot clean it up), but unprep_seqs_ is otherwise preserved so the transaction can still be rolled back once the caller resumes the DB from the write error. Originally authored by Devmate trigger Reviewed By: xingbowang Differential Revision: D110271443 fbshipit-source-id: 7d991e01ddc74ccd170cbc25f6af160c5f3d5663
RocksDB: A Persistent Key-Value Store for Flash and RAM Storage
RocksDB is developed and maintained by Facebook Database Engineering Team. It is built on earlier work on LevelDB by Sanjay Ghemawat (sanjay@google.com) and Jeff Dean (jeff@google.com)
This code is a library that forms the core building block for a fast key-value server, especially suited for storing data on flash drives. It has a Log-Structured-Merge-Database (LSM) design with flexible tradeoffs between Write-Amplification-Factor (WAF), Read-Amplification-Factor (RAF) and Space-Amplification-Factor (SAF). It has multi-threaded compactions, making it especially suitable for storing multiple terabytes of data in a single database.
Start with example usage here: https://github.com/facebook/rocksdb/tree/main/examples
See the github wiki for more explanation.
The public interface is in include/. Callers should not include or
rely on the details of any other header files in this package. Those
internal APIs may be changed without warning.
Questions and discussions are welcome on the RocksDB Developers Public Facebook group and email list on Google Groups.
License
RocksDB is dual-licensed under both the GPLv2 (found in the COPYING file in the root directory) and Apache 2.0 License (found in the LICENSE.Apache file in the root directory). You may select, at your option, one of the above-listed licenses.