database/rocksdb
1
0
Fork 0
mirror of https://github.com/facebook/rocksdb.git synced 2026-10-23 08:09:02 +03:00
Code Activity

Update error logging and status reporting for unsupported iouring (#13936)

Browse Source 
Summary:
We should add error logging to be able to pinpoint why RocksDB is returning status `NotSupported` for `ReadAsync`.

Pull Request resolved: https://github.com/facebook/rocksdb/pull/13936

Test Plan: Look at logs (and client logs of error status)

Reviewed By: anand1976

Differential Revision: D82141529

Pulled By: archang19

fbshipit-source-id: c71b70967457be35ef5168321d449f96b2b9441d
This commit is contained in:
Andrew Chang
2025-09-10 17:54:26 -07:00
committed by Facebook GitHub Bot
parent f46242cef6
commit d87e598f70
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
env/io_posix.cc vendored
View File

@@ -935,7 +935,8 @@ IOStatus PosixRandomAccessFile::ReadAsync(
// Init failed, platform doesn't support io_uring.
if (iu == nullptr) {
return IOStatus::NotSupported("ReadAsync");
fprintf(stderr, "failed to init io_uring\n");
return IOStatus::NotSupported("ReadAsync: failed to init io_uring");
}
// Allocate io_handle.
@@ -978,7 +979,8 @@ IOStatus PosixRandomAccessFile::ReadAsync(
(void)cb_arg;
(void)io_handle;
(void)del_fn;
return IOStatus::NotSupported("ReadAsync");
return IOStatus::NotSupported(
"ReadAsync: ROCKSDB_IOURING_PRESENT is not set");
#endif
}