mirror of
https://github.com/postgres/postgres.git
synced 2026-10-23 13:29:09 +03:00
edfa6c8fcb
Previously, pg_locks.waitstart could report the start time of a previous lock wait for a new wait. For a regular backend, this could happen briefly before the new start time was stored. On a standby, the startup process could show the old time throughout the next wait, making it appear to have started earlier than it did. This happened because PGPROC->waitStart could remain set after a previous wait in two cases. First, RemoveFromWaitQueue() did not clear it when a wait was canceled due to a lock timeout, cancellation, or deadlock. Second, even after a successful lock grant, ProcWakeup() could clear it before the waiter stored its new start time. Fix this by clearing waitStart in RemoveFromWaitQueue() when a failed wait is removed, at the end of ProcSleep() to handle writes made after ProcWakeup() cleared it, and in LockErrorCleanup() when an error bypasses the ProcSleep() reset. This prevents pg_locks.waitstart from showing the previous wait's time for a new wait. Backpatch to all supported versions. Author: Shihao Zhong <zhong950419@gmail.com> Reported-by: Alex Shapalov <shapalov@gmail.com> Reviewed-by: Chao Li <li.evan.chao@gmail.com> Reviewed-by: Michael Paquier <michael@paquier.xyz> Reviewed-by: Fujii Masao <masao.fujii@gmail.com> Reviewed-by: Andrew Krylosov <krylosov.andrew@gmail.com> Discussion: https://postgr.es/m/CAPrb+Q+XN=sNusXiUeWmMo2H7Qgq3Y4uPekSSLkHcnCyf7GhXg@mail.gmail.com Discussion: https://postgr.es/m/CAGRkXqQLxZBr-ouVrtaX2utMggi4+TiVMbgH04b_0JLgKryxbA@mail.gmail.com Backpatch-through: 14
PostgreSQL Database Management System ===================================== This directory contains the source code distribution of the PostgreSQL database management system. PostgreSQL is an advanced object-relational database management system that supports an extended subset of the SQL standard, including transactions, foreign keys, subqueries, triggers, user-defined types and functions. This distribution also contains C language bindings. PostgreSQL has many language interfaces, many of which are listed here: https://www.postgresql.org/download/ See the file INSTALL for instructions on how to build and install PostgreSQL. That file also lists supported operating systems and hardware platforms and contains information regarding any other software packages that are required to build or run the PostgreSQL system. Copyright and license information can be found in the file COPYRIGHT. A comprehensive documentation set is included in this distribution; it can be read as described in the installation instructions. The latest version of this software may be obtained at https://www.postgresql.org/download/. For more information look at our web site located at https://www.postgresql.org/.