Buildfarm testing shows that OpenSUSE (and perhaps related platforms?) configures GNU tar in such a way that it'll archive sparse WAL files by default, thus triggering the pax-extension detection code added bybc30c704a. Thus, we need something similar to852de579abut for GNU tar's option set. "--format=ustar" seems to do the trick. Moreover, the buildfarm shows that pg_verifybackup's 003_corruption.pl test script is also triggering creation of pax-format tar files on that platform. We had not noticed because those test cases all fail (intentionally) before getting to the point of trying to verify WAL data. Since that means two TAP scripts need this option-selection logic, and plausibly more will do so in future, factor it out into a subroutine in Test::Utils. We also need to back-patch the 003_corruption.pl fix into v18, where it's also failing. While at it, clean up some places where guards for $tar being empty or undefined were incomplete or even outright backwards. Presumably, we missed noticing because the set of machines that run TAP tests and don't have tar installed is empty. But if we're going to try to handle that scenario, we should do it correctly. Reported-by: Tomas Vondra <tomas@vondra.me> Author: Tom Lane <tgl@sss.pgh.pa.us> Discussion: https://postgr.es/m/02770bea-b3f3-4015-8a43-443ae345379c@vondra.me Backpatch-through: 18
PostgreSQL Database Management System
This directory contains the source code distribution of the PostgreSQL database management system.
PostgreSQL is an advanced object-relational database management system that supports an extended subset of the SQL standard, including transactions, foreign keys, subqueries, triggers, user-defined types and functions. This distribution also contains C language bindings.
Copyright and license information can be found in the file COPYRIGHT.
General documentation about this version of PostgreSQL can be found at https://www.postgresql.org/docs/devel/. In particular, information about building PostgreSQL from the source code can be found at https://www.postgresql.org/docs/devel/installation.html.
The latest version of this software, and related software, may be obtained at https://www.postgresql.org/download/. For more information look at our web site located at https://www.postgresql.org/.