e484b0eea6
First, under CLOBBER_CACHE_ALWAYS, the RI_ConstraintInfo entry can be invalidated by relcache callbacks triggered inside table_open() or index_open(), leaving ri_FastPathCheck() calling ri_populate_fastpath_metadata() with a stale entry whose valid flag is false. Fix by moving the fpmeta initialization to after ri_CheckPermissions(), reloading riinfo first to ensure it is valid, then calling ri_ExtractValues() and build_index_scankeys() immediately after before any further operations that could trigger invalidation. Second, fpmeta allocated in TopMemoryContext was not freed when the entry was invalidated in InvalidateConstraintCacheCallBack(), leaking memory each time the constraint cache entry was recycled. Fix by freeing and NULLing fpmeta at invalidation time. Noticed locally when testing with CLOBBER_CACHE_ALWAYS. Discussion: https://postgr.es/m/CA+HiwqGBU__7-VZZhQWQ3EQuwLYNPd9==ngnzduhGWKHMj9mvw@mail.gmail.com
PostgreSQL Database Management System
This directory contains the source code distribution of the PostgreSQL database management system.
PostgreSQL is an advanced object-relational database management system that supports an extended subset of the SQL standard, including transactions, foreign keys, subqueries, triggers, user-defined types and functions. This distribution also contains C language bindings.
Copyright and license information can be found in the file COPYRIGHT.
General documentation about this version of PostgreSQL can be found at https://www.postgresql.org/docs/devel/. In particular, information about building PostgreSQL from the source code can be found at https://www.postgresql.org/docs/devel/installation.html.
The latest version of this software, and related software, may be obtained at https://www.postgresql.org/download/. For more information look at our web site located at https://www.postgresql.org/.