c5666f7e16
ReplicationSlotRelease() copied MyProc->statusFlags unconditionally when resetting PROC_IN_LOGICAL_DECODING, using its pgxactoff to decide which area to update. Slot invalidations can be done by the checkpointer or the startup process, and ReplicationSlotRelease() ignored the fact that pgxactoff is only meaningful for processes in the proc array, that auxiliary processes never join. pgxactoff would remain at 0 for these, meaning that an incorrect set of status flags would be updated. The consequences of this issue could be various, depending on the statsFlags lost in the proc slot incorrectly overwritten. Losing PROC_AFFECTS_ALL_HORIZONS has been mentioned as the worse case, causing VACUUM to remove rows a standby may needs even if standby feedback is enabled. Assertions failures are another possibility. Let's skip the update of statusFlags unless PROC_IN_LOGICAL_DECODING is set. Nothing but StartupDecodingContext() sets it, and no auxiliary processes call it. Author: Vlad Lesin <vladlesin@gmail.com> Reviewed-by: Hayato Kuroda <kuroda.hayato@fujitsu.com> Reviewed-by: Michael Paquier <michael@paquier.xyz> Discussion: https://postgr.es/m/889a06dd-45fc-423b-9dd2-87d5b5dc60c6@gmail.com Backpatch-through: 14
PostgreSQL Database Management System
This directory contains the source code distribution of the PostgreSQL database management system.
PostgreSQL is an advanced object-relational database management system that supports an extended subset of the SQL standard, including transactions, foreign keys, subqueries, triggers, user-defined types and functions. This distribution also contains C language bindings.
Copyright and license information can be found in the file COPYRIGHT.
General documentation about this version of PostgreSQL can be found at https://www.postgresql.org/docs/18/. In particular, information about building PostgreSQL from the source code can be found at https://www.postgresql.org/docs/18/installation.html.
The latest version of this software, and related software, may be obtained at https://www.postgresql.org/download/. For more information look at our web site located at https://www.postgresql.org/.