database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-04-22 23:02:54 +03:00
Code

Remove rare corner case for data loss when triggering standby server.

Browse Source 
If the standby was streaming when trigger file arrives, check also in the
archive for additional WAL files. This is a corner case since it is
unlikely that we would trigger a failover while the master is still
available and sending data to standby, while at the same time running in
archive mode and also while the streaming standby has fallen behind archive.
Someone would eventually be unlucky; we must plug all gaps however small.

Fujii Masao
This commit is contained in:
Simon Riggs 2011-02-08 14:38:02 +00:00
parent 722bf7017b
commit faa0550572
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/backend/access/transam/xlog.c
View File

@ -9619,7 +9619,7 @@ retry:
* five seconds like in the WAL file polling case below.
*/
if (CheckForStandbyTrigger())
goto triggered;
goto retry;
/*
* Wait for more WAL to arrive, or timeout to be reached
@ -9886,6 +9886,10 @@ static bool
CheckForStandbyTrigger(void)
{
struct stat stat_buf;
static bool triggered = false;
if (triggered)
return true;
if (TriggerFile == NULL)
return false;
@ -9896,6 +9900,7 @@ CheckForStandbyTrigger(void)
(errmsg("trigger file found: %s", TriggerFile)));
ShutdownWalRcv();
unlink(TriggerFile);
triggered = true;
return true;
}
return false;