mirror of
https://github.com/postgres/postgres.git
synced 2025-04-22 23:02:54 +03:00
Fix corner case in autovacuum-forcing logic for multixact wraparound.
Since find_multixact_start() relies on SimpleLruDoesPhysicalPageExist(), and that function looks only at the on-disk state, it's possible for it to fail to find a page that exists in the in-memory SLRU that has not been written yet. If that happens, SetOffsetVacuumLimit() will erroneously decide to force emergency autovacuuming immediately. We should probably fix find_multixact_start() to consider the data cached in memory as well as on the on-disk state, but that's no excuse for SetOffsetVacuumLimit() to be stupid about the case where it can no longer read the value after having previously succeeded in doing so. Report by Andres Freund.
This commit is contained in:
parent
86e4751786
commit
ed16f73c57
@ -2661,6 +2661,18 @@ SetOffsetVacuumLimit(bool finish_setup)
|
||||
(errmsg("oldest MultiXactId member offset unknown")));
|
||||
}
|
||||
|
||||
/*
|
||||
* If we failed to get the oldest offset this time, but we have a value
|
||||
* from a previous pass through this function, assess the need for
|
||||
* autovacuum based on that old value rather than automatically forcing
|
||||
* it.
|
||||
*/
|
||||
if (prevOldestOffsetKnown && !oldestOffsetKnown)
|
||||
{
|
||||
oldestOffset = prevOldestOffset;
|
||||
oldestOffsetKnown = true;
|
||||
}
|
||||
|
||||
/*
|
||||
* Do we need an emergency autovacuum? If we're not sure, assume yes.
|
||||
*/
|
||||
|
Loading…
x
Reference in New Issue
Block a user