database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2026-10-23 13:29:09 +03:00
Code Activity

pgcrypto: remove unused field mdc_checked from PGP_Context

Browse Source 
mdc_finish used to set this field once it had successfully verified
the MDC packet, with its only reader in the same function.  This was
removed by a59ee88197 when mdc_finish stopped being called through
the pullf_read API, the field has been unused since.

Note that MDC verification does not rely on it: process_data_packets
tracks whether an MDC packet was seen in its local got_mdc variable
and rejects the message if a required MDC is missing, while the
use_mdcbuf_filter path checks the hash in mdcbuf_finish().

Author: Aleksander Alekseev <aleksander@tigerdata.com>
Discussion: https://postgr.es/m/CAJ7c6TNmHnnCkn3uZwRUE7WWYftW--48JFoDVDqoZqMrLYxUZw@mail.gmail.com
This commit is contained in:
Daniel Gustafsson
2026-08-13 13:18:12 +02:00
parent 72e6184cd5
commit e8a8ccc3ca
2 changed files with 0 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
contrib/pgcrypto/pgp-decrypt.c
View File

@@ -388,7 +388,6 @@ mdc_finish(PGP_Context *ctx, PullFilter *src, int len)
px_debug("mdc_finish: mdc failed");
return PXE_PGP_CORRUPT_DATA;
}
ctx->mdc_checked = 1;
return 0;
}

1
contrib/pgcrypto/pgp.h
View File

@@ -156,7 +156,6 @@ struct PGP_Context
/*
* internal variables
*/
int mdc_checked;
int corrupt_prefix; /* prefix failed RFC 4880 "quick check" */
int unsupported_compr; /* has bzip2 compression */
int unexpected_binary; /* binary data seen in text_mode */