database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-04-22 23:02:54 +03:00
Code

Also trigger restartpoints based on max_wal_size on standby.

Browse Source 
When archive recovery and restartpoints were initially introduced,
checkpoint_segments was ignored on the grounds that the files restored from
archive don't consume any space in the recovery server. That was changed in
later releases, but even then it was arguably a feature rather than a bug,
as performing restartpoints as often as checkpoints during normal operation
might be excessive, but you might nevertheless not want to waste a lot of
space for pre-allocated WAL by setting checkpoint_segments to a high value.
But now that we have separate min_wal_size and max_wal_size settings, you
can bound WAL usage with max_wal_size, and still avoid consuming excessive
space usage by setting min_wal_size to a lower value, so that argument is
moot.

There are still some issues with actually limiting the space usage to
max_wal_size: restartpoints in recovery can only start after seeing the
checkpoint record, while a checkpoint starts flushing buffers as soon as
the redo-pointer is set. Restartpoint is paced to happen at the same
leisurily speed, determined by checkpoint_completion_target, as checkpoints,
but because they are started later, max_wal_size can be exceeded by upto
one checkpoint cycle's worth of WAL, depending on
checkpoint_completion_target. But that seems better than not trying at all,
and max_wal_size is a soft limit anyway.

The documentation already claimed that max_wal_size is obeyed in recovery,
so this just fixes the behaviour to match the docs. However, add some
weasel-words there to mention that max_wal_size may well be exceeded by
some amount in recovery.
This commit is contained in:
Heikki Linnakangas 2015-06-29 00:09:10 +03:00
parent 6ab4d38ab0
commit d661532e27
3 changed files with 29 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
doc/src/sgml/wal.sgml
View File

@ -590,7 +590,11 @@
A restartpoint is triggered when a checkpoint record is reached if at A restartpoint is triggered when a checkpoint record is reached if at
least <varname>checkpoint_timeout</> seconds have passed since the last least <varname>checkpoint_timeout</> seconds have passed since the last
restartpoint, or if WAL size is about to exceed restartpoint, or if WAL size is about to exceed
<varname>max_wal_size</>. <varname>max_wal_size</>. However, because of limitations on when a
restartpoint can be performed, <varname>max_wal_size</> is often exceeded
during recovery, by up to one checkpoint cycle's worth of WAL.
(<varname>max_wal_size</> is never a hard limit anyway, so you should
always leave plenty of headroom to avoid running out of disk space.)
</para> </para>
<para> <para>

2
src/backend/access/transam/xlog.c
View File

@ -10943,7 +10943,7 @@ XLogPageRead(XLogReaderState *xlogreader, XLogRecPtr targetPagePtr, int reqLen,
* Request a restartpoint if we've replayed too much xlog since the * Request a restartpoint if we've replayed too much xlog since the
* last one. * last one.
*/ */
if (StandbyModeRequested && bgwriterLaunched) if (bgwriterLaunched)
{ {
if (XLogCheckpointNeeded(readSegNo)) if (XLogCheckpointNeeded(readSegNo))
{ {

24
src/backend/postmaster/checkpointer.c
View File

@ -475,10 +475,12 @@ CheckpointerMain(void)
/* /*
* Initialize checkpointer-private variables used during * Initialize checkpointer-private variables used during
* checkpoint * checkpoint.
*/ */
ckpt_active = true; ckpt_active = true;
if (!do_restartpoint) if (do_restartpoint)
ckpt_start_recptr = GetXLogReplayRecPtr(NULL);
else
ckpt_start_recptr = GetInsertRecPtr(); ckpt_start_recptr = GetInsertRecPtr();
ckpt_start_time = now; ckpt_start_time = now;
ckpt_cached_elapsed = 0; ckpt_cached_elapsed = 0;
@ -720,7 +722,7 @@ CheckpointWriteDelay(int flags, double progress)
/* /*
* IsCheckpointOnSchedule -- are we on schedule to finish this checkpoint * IsCheckpointOnSchedule -- are we on schedule to finish this checkpoint
* in time? * (or restartpoint) in time?
* *
* Compares the current progress against the time/segments elapsed since last * Compares the current progress against the time/segments elapsed since last
* checkpoint, and returns true if the progress we've made this far is greater * checkpoint, and returns true if the progress we've made this far is greater
@ -757,9 +759,20 @@ IsCheckpointOnSchedule(double progress)
* compares against RedoRecptr, so this is not completely accurate. * compares against RedoRecptr, so this is not completely accurate.
* However, it's good enough for our purposes, we're only calculating an * However, it's good enough for our purposes, we're only calculating an
* estimate anyway. * estimate anyway.
*
* During recovery, we compare last replayed WAL record's location with
* the location computed before calling CreateRestartPoint. That maintains
* the same pacing as we have during checkpoints in normal operation, but
* we might exceed max_wal_size by a fair amount. That's because there can
* be a large gap between a checkpoint's redo-pointer and the checkpoint
* record itself, and we only start the restartpoint after we've seen the
* checkpoint record. (The gap is typically up to CheckPointSegments *
* checkpoint_completion_target where checkpoint_completion_target is the
* value that was in effect when the WAL was generated).
*/ */
if (!RecoveryInProgress()) if (RecoveryInProgress())
{ recptr = GetXLogReplayRecPtr(NULL);
else
recptr = GetInsertRecPtr(); recptr = GetInsertRecPtr();
elapsed_xlogs = (((double) (recptr - ckpt_start_recptr)) / XLogSegSize) / CheckPointSegments; elapsed_xlogs = (((double) (recptr - ckpt_start_recptr)) / XLogSegSize) / CheckPointSegments;
@ -768,7 +781,6 @@ IsCheckpointOnSchedule(double progress)
ckpt_cached_elapsed = elapsed_xlogs; ckpt_cached_elapsed = elapsed_xlogs;
return false; return false;
} }
}
/* /*
* Check progress against time elapsed and checkpoint_timeout. * Check progress against time elapsed and checkpoint_timeout.