database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-11-01 21:31:19 +03:00
Code Activity

In src/include/mb/pg_wchar.h we have:

Browse Source 
#define PG_ENCODING_BE_LAST PG_ISO_8859_8
#define PG_ENCODING_FE_LAST PG_WIN1256

but the last client encoding in the enum list is actually PG_GB18030 and
it seems that

#define PG_ENCODING_IS_CLIEN_ONLY(_enc) \
                (((_enc) > PG_ENCODING_BE_LAST && (_enc) <= PG_ENCODING_FE_LAST)

can never be true.

I think the define should read
#define PG_ENCODING_FE_LAST PG_GB18030

On the other hand, perhaps no-one cares, because
PG_ENCODING_IS_CLIEN_ONLY is never used.

--
Oliver Elphick                                Oliver.Elphick@lfix.co.uk
This commit is contained in:
Bruce Momjian
2003-06-02 18:59:25 +00:00
parent 1c5e716882
commit cb36e74ee6
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/include/mb/pg_wchar.h
View File

@@ -1,4 +1,4 @@
/* $Id: pg_wchar.h,v 1.45 2003/02/19 14:31:26 ishii Exp $ */
/* $Id: pg_wchar.h,v 1.46 2003/06/02 18:59:25 momjian Exp $ */
#ifndef PG_WCHAR_H
#define PG_WCHAR_H
@@ -190,7 +190,7 @@ typedef enum pg_enc
} pg_enc;
#define PG_ENCODING_BE_LAST PG_ISO_8859_8
#define PG_ENCODING_FE_LAST PG_WIN1256
#define PG_ENCODING_FE_LAST PG_GB18030
/*
* Please use these tests before access to pg_encconv_tbl[]