database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2026-10-23 13:29:09 +03:00
Code Activity

Make sure to detach injection points for re-attaching

Browse Source 
The new test for enabling data checksums with concurrent CREATE
DATABASE calls use the same injection points as a previous test
but accidentally missed detaching the injection point first.

Fix by detaching the injection point in the PG_TEST_EXTRA SKIP
block to make it can be reused.  Pointed out by buildfarm member
porpoise which failed with:

    die: error running SQL: 'psql:<stdin>:1:
	     ERROR: injection point "datachecksumsworker-fake-temptable-wait"
		        already defined'

Backpatch to v19 where online checksums were introduced.

Author: Daniel Gustafsson <daniel@yesql.se>
Reported-by: Buildfarm member porpoise
Reviewed-by: Jonathan Gonzalez V. <jonathan.abdiel@gmail.com>
Discussion: https://postgr.es/m/28CF6FD9-E1C4-4C04-8270-E3305AC46171@yesql.se
Backpatch-through: 19
This commit is contained in:
Daniel Gustafsson
2026-07-30 12:41:40 +02:00
parent 28511528ae
commit ca7709f78f
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/test/modules/test_checksums/t/005_injection.pl
View File

@@ -74,6 +74,9 @@ SKIP:
"SELECT injection_points_attach('datachecksumsworker-fake-temptable-wait', 'notice');"
);
enable_data_checksums($node, wait => 'on');
$node->safe_psql('postgres',
"SELECT injection_points_detach('datachecksumsworker-fake-temptable-wait');"
);
}
# ---------------------------------------------------------------------------