database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-15 19:21:59 +03:00
Code Activity

Add function for removing arbitrary nodes in binaryheap.

Browse Source 
This commit introduces binaryheap_remove_node(), which can be used
to remove any node from a binary heap.  The implementation is
straightforward.  The target node is replaced with the last node in
the heap, and then we sift as needed to preserve the heap property.
This new function is intended for use in a follow-up commit that
will improve the performance of pg_restore.

Reviewed-by: Tom Lane
Discussion: https://postgr.es/m/3612876.1689443232%40sss.pgh.pa.us
This commit is contained in:
Nathan Bossart
2023-09-18 14:06:08 -07:00
parent 83223f5f71
commit c103d07381
2 changed files with 32 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
src/common/binaryheap.c
View File

@ -215,6 +215,35 @@ binaryheap_remove_first(binaryheap *heap)
return result;
}
/*
* binaryheap_remove_node
*
* Removes the nth (zero based) node from the heap. The caller must ensure
* that there are at least (n + 1) nodes in the heap. O(log n) worst case.
*/
void
binaryheap_remove_node(binaryheap *heap, int n)
{
int cmp;
Assert(!binaryheap_empty(heap) && heap->bh_has_heap_property);
Assert(n >= 0 && n < heap->bh_size);
/* compare last node to the one that is being removed */
cmp = heap->bh_compare(heap->bh_nodes[--heap->bh_size],
heap->bh_nodes[n],
heap->bh_arg);
/* remove the last node, placing it in the vacated entry */
heap->bh_nodes[n] = heap->bh_nodes[heap->bh_size];
/* sift as needed to preserve the heap property */
if (cmp > 0)
sift_up(heap, n);
else if (cmp < 0)
sift_down(heap, n);
}
/*
* binaryheap_replace_first
*