database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-05-03 22:24:49 +03:00
Code

Disallow UNION/INTERSECT/EXCEPT over no columns.

Browse Source 
Since 9.4, we've allowed the syntax "select union select" and variants
of that.  However, the planner wasn't expecting a no-column set operation
and ended up treating the set operation as if it were UNION ALL.

Pre-v10, there seem to be some executor issues that would need to be
fixed to support such cases, and it doesn't really seem worth expending
much effort on.  Just disallow it, instead.

Per report from Victor Yegorov.

Discussion: https://postgr.es/m/CAGnEbojGJrRSOgJwNGM7JSJZpVAf8xXcVPbVrGdhbVEHZ-BUMw@mail.gmail.com
This commit is contained in:
Tom Lane 2017-12-22 12:08:28 -05:00
parent 23b63417e2
commit bd29bc417e
1 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/backend/optimizer/prep/prepunion.c
View File

@ -697,9 +697,13 @@ generate_nonunion_path(SetOperationStmt *op, PlannerInfo *root,
/* Identify the grouping semantics */
groupList = generate_setop_grouplist(op, tlist);
/* punt if nothing to group on (can this happen?) */
/* punt if nothing to group on (not worth fixing in back branches) */
if (groupList == NIL)
return path;
ereport(ERROR,
(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
/* translator: %s is UNION, INTERSECT, or EXCEPT */
errmsg("%s over no columns is not supported",
(op->op == SETOP_INTERSECT) ? "INTERSECT" : "EXCEPT")));
/*
* Estimate number of distinct groups that we'll need hashtable entries
@ -850,9 +854,12 @@ make_union_unique(SetOperationStmt *op, Path *path, List *tlist,
/* Identify the grouping semantics */
groupList = generate_setop_grouplist(op, tlist);
/* punt if nothing to group on (can this happen?) */
/* punt if nothing to group on (not worth fixing in back branches) */
if (groupList == NIL)
return path;
ereport(ERROR,
(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),
/* translator: %s is UNION, INTERSECT, or EXCEPT */
errmsg("%s over no columns is not supported", "UNION")));
/*
* XXX for the moment, take the number of distinct groups as equal to the