database/postgres
database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-05-26 18:17:33 +03:00
Code

Improve comment about dropped entries in pgstat.c

Browse Source 
pgstat_write_statsfile() discards any entries marked as dropped from
being written to the stats file at shutdown, and also included an
assertion based on the same condition.

The intention of the assertion is to track that no pgstats entries
should be left around as terminating backends should drop any entries
they still hold references on before the stats file is written by the
checkpointer, and it not worth taking down the server in this case if
there is a bug making that possible.

Let's improve the comment of this area to document clearly what's
intended.

Based on a discussion with Bertrand Drouvot and Anton A. Melnikov.

Author: Bertrand Drouvot
Discussion: https://postgr.es/m/a13e8cdf-b97a-4ecb-8f42-aaa367974e29@postgrespro.ru
Backpatch-through: 15
This commit is contained in:
Michael Paquier 2024-12-09 14:35:44 +09:00
parent dc5f905418
commit bb93b33d7e
1 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
src/backend/utils/activity/pgstat.c
View File

@ -1396,7 +1396,15 @@ pgstat_write_statsfile(void)
CHECK_FOR_INTERRUPTS();
/* we may have some "dropped" entries not yet removed, skip them */
/*
* We should not see any "dropped" entries when writing the stats
* file, as all backends and auxiliary processes should have cleaned
* up their references before they terminated.
*
* However, since we are already shutting down, it is not worth
* crashing the server over any potential cleanup issues, so we simply
* skip such entries if encountered.
*/
Assert(!ps->dropped);
if (ps->dropped)
continue;