database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-10-16 17:07:43 +03:00
Code Activity

Reduce ExecSeqScan* code size using pg_assume()

Browse Source 
fb9f955025 optimized code generation by using specialized variants of
ExecSeqScan* for [not] having a qual, projection etc. This allowed the
compiler to optimize the code out the code for qual / projection. However, as
observed by David Rowley at the time, the compiler couldn't prove the
opposite, i.e. that the qual etc *are* present.

By using pg_assume(), introduced in d65eb5b1b8, we can tell the compiler that
the relevant variables are non-null.

This reduces the code size to a surprising degree and seems to lead to a small
but reproducible performance gain.

Reviewed-by: Amit Langote <amitlangote09@gmail.com> Discussion:
https://postgr.es/m/CA+HiwqFk-MbwhfX_kucxzL8zLmjEt9MMcHi2YF=DyhPrSjsBEA@mail.gmail.com
This commit is contained in:
Andres Freund
2025-08-11 15:41:34 -04:00
parent 01d6832c10
commit b227b0bb4e
1 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/backend/executor/nodeSeqscan.c
View File

@@ -131,8 +131,12 @@ ExecSeqScanWithQual(PlanState *pstate)
{
SeqScanState *node = castNode(SeqScanState, pstate);
/*
* Use pg_assume() for != NULL tests to make the compiler realize no
* runtime check for the field is needed in ExecScanExtended().
*/
Assert(pstate->state->es_epq_active == NULL);
Assert(pstate->qual != NULL);
pg_assume(pstate->qual != NULL);
Assert(pstate->ps_ProjInfo == NULL);
return ExecScanExtended(&node->ss,
@@ -153,7 +157,7 @@ ExecSeqScanWithProject(PlanState *pstate)
Assert(pstate->state->es_epq_active == NULL);
Assert(pstate->qual == NULL);
Assert(pstate->ps_ProjInfo != NULL);
pg_assume(pstate->ps_ProjInfo != NULL);
return ExecScanExtended(&node->ss,
(ExecScanAccessMtd) SeqNext,
@@ -173,8 +177,8 @@ ExecSeqScanWithQualProject(PlanState *pstate)
SeqScanState *node = castNode(SeqScanState, pstate);
Assert(pstate->state->es_epq_active == NULL);
Assert(pstate->qual != NULL);
Assert(pstate->ps_ProjInfo != NULL);
pg_assume(pstate->qual != NULL);
pg_assume(pstate->ps_ProjInfo != NULL);
return ExecScanExtended(&node->ss,
(ExecScanAccessMtd) SeqNext,