database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2026-10-23 13:29:09 +03:00
Code Activity

oauth_validator: Remove racing GUC check

Browse Source 
Follow-up to bca67e5a3. The test added there changed the value of
oauth_validator_libraries, waited for the postmaster to apply it, and
verified the change on an existing background connection. But there's no
guarantee that the SIGHUP will have arrived and completed its work on
existing backends by that time, so the final test flaked.

We only care about the postmaster's state here, since we're testing the
GUC's effects on newly forked backends, so remove the background check
entirely.

Per buildfarm member serinus.

Reported-by: Alexander Lakhin <exclusion@gmail.com>
Discussion: https://postgr.es/m/a37a3cea-5bd8-4385-a1d4-bb89394c079c%40gmail.com
Backpatch-through: 18
This commit is contained in:
Jacob Champion
2026-10-08 10:58:18 -07:00
parent 1370a7832a
commit af28fc13e2
1 changed files with 0 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/test/modules/oauth_validator/t/001_server.pl
View File

@@ -111,8 +111,6 @@ $node->reload;
$log_start = $node->wait_for_log(
qr/parameter "oauth_validator_libraries" changed to "validator"/,
$log_start);
is($bgconn->query_safe('SHOW oauth_validator_libraries'),
'validator', 'oauth_validator_libraries restored');
# To test against HTTP rather than HTTPS, we need to enable PGOAUTHDEBUG. But
# first, check to make sure the client refuses such connections by default.