database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-10-18 04:29:09 +03:00
Code Activity

Rewrite previous commit's test for TestUpgradeXversion compatibility.

Browse Source 
v17 introduced the MAINTAIN ON TABLES privilege.  That changed the
applicable "baseacls" reaching buildACLCommands().  That yielded
spurious TestUpgradeXversion diffs.  Change to use a TYPES privilege.
Types have the same one privilege in all supported versions, so they
avoid the problem.  Per buildfarm.  Back-patch to v13, like that commit.

Discussion: https://postgr.es/m/20250823144505.88.nmisch@google.com
Backpatch-through: 13
This commit is contained in:
Noah Misch
2025-08-23 16:46:20 -07:00
parent b61a5c4bed
commit ad4412480d
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/test/regress/expected/privileges.out
View File

@@ -3155,9 +3155,9 @@ DROP USER regress_priv_user8; -- does not exist
ERROR: role "regress_priv_user8" does not exist
-- leave some default ACLs for pg_upgrade's dump-restore test input.
ALTER DEFAULT PRIVILEGES FOR ROLE pg_signal_backend
REVOKE INSERT ON TABLES FROM pg_signal_backend;
REVOKE USAGE ON TYPES FROM pg_signal_backend;
ALTER DEFAULT PRIVILEGES FOR ROLE pg_read_all_settings
REVOKE INSERT ON TABLES FROM pg_read_all_settings;
REVOKE USAGE ON TYPES FROM pg_read_all_settings;
-- permissions with LOCK TABLE
CREATE USER regress_locktable_user;
CREATE TABLE lock_table (a int);

4
src/test/regress/sql/privileges.sql
View File

@@ -1865,9 +1865,9 @@ DROP USER regress_priv_user8; -- does not exist
-- leave some default ACLs for pg_upgrade's dump-restore test input.
ALTER DEFAULT PRIVILEGES FOR ROLE pg_signal_backend
REVOKE INSERT ON TABLES FROM pg_signal_backend;
REVOKE USAGE ON TYPES FROM pg_signal_backend;
ALTER DEFAULT PRIVILEGES FOR ROLE pg_read_all_settings
REVOKE INSERT ON TABLES FROM pg_read_all_settings;
REVOKE USAGE ON TYPES FROM pg_read_all_settings;
-- permissions with LOCK TABLE