database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2026-10-23 13:29:09 +03:00
Code Activity

Do not reuse rd_smgr in fork loop when enabling data checksums

Browse Source 
ProcessSingleRelationByOid called RelationGetSmgr(rel), discarded the
result, and then read rel->rd_smgr directly when looping over forks.
Only RelationGetSmgr is authorized to read that field since a relcache
invalidation resets rd_smgr to NULL.

Backpatch to v19 where online checksums were introduced.

Author: Mihail Nikalayeu <mihailnikalayeu@gmail.com>
Reviewed-by: ChangAo Chen <cca5507@qq.com>
Reviewed-by: Fujii Masao <masao.fujii@gmail.com>
Discussion: https://postgr.es/m/CADzfLwXGvb4Y-mqy8T+O0f_tkXR1sTDBGzP5Z=V_qcGnZ46rWg@mail.gmail.com
Backpatch-through: 19
This commit is contained in:
Daniel Gustafsson
2026-08-04 12:16:55 +02:00
parent 346fbdcc2a
commit ab918a4fab
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/backend/postmaster/datachecksum_state.c
View File

@@ -841,11 +841,10 @@ ProcessSingleRelationByOid(Oid relationId, BufferAccessStrategy strategy)
pgstat_report_activity(STATE_IDLE, NULL);
return true;
}
RelationGetSmgr(rel);
for (ForkNumber fnum = 0; fnum <= MAX_FORKNUM; fnum++)
{
if (smgrexists(rel->rd_smgr, fnum))
if (smgrexists(RelationGetSmgr(rel), fnum))
{
if (!ProcessSingleRelationFork(rel, fnum, strategy))
{