database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-10-28 11:55:03 +03:00
Code Activity

Reduce chattiness of genbki.pl and Gen_fmgrtab.pl.

Browse Source 
Make these scripts emit just one log message when they run, not one
per output file.  The latter is way too verbose in the wake of
commit 372728b0d.  The specific wording used is what already existed
in the MSVC scripts.

John Naylor

Discussion: https://postgr.es/m/11103.1523208822@sss.pgh.pa.us
This commit is contained in:
Tom Lane
2018-04-09 15:01:10 -04:00
parent 2cdf359fc4
commit a65e17bd6f
4 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
src/backend/catalog/Catalog.pm
View File

@@ -340,7 +340,6 @@ sub RenameTempFile
my $final_name = shift;
my $extension = shift;
my $temp_name = $final_name . $extension;
print "Writing $final_name\n";
rename($temp_name, $final_name) || die "rename: $temp_name: $!";
}

1
src/backend/catalog/genbki.pl
View File

@@ -217,6 +217,7 @@ my %lookup_kind = (
# Generate postgres.bki, postgres.description, postgres.shdescription,
# and pg_*_d.h headers.
print "Generating BKI files and symbol definition headers...\n";
# version marker for .bki file
print $bki "# PostgreSQL $major_version\n";

2
src/backend/utils/Gen_fmgrtab.pl
View File

@@ -84,6 +84,8 @@ my $FirstBootstrapObjectId = Catalog::FindDefinedSymbol(
my $INTERNALlanguageId = Catalog::FindDefinedSymbolFromData(
$catalog_data{pg_language}, 'INTERNALlanguageId');
print "Generating fmgrtab.c, fmgroids.h, and fmgrprotos.h...\n";
# Collect certain fields from pg_proc.dat.
my @fmgr = ();

2
src/tools/msvc/Solution.pm
View File

@@ -275,7 +275,6 @@ s{PG_VERSION_STR "[^"]+"}{PG_VERSION_STR "PostgreSQL $self->{strver}$extraver, c
'fmgrtab.c', '../../../src/include/access/transam.h')
)
{
print "Generating fmgrtab.c, fmgroids.h, fmgrprotos.h...\n";
system(
"perl -I ../catalog Gen_fmgrtab.pl -I../../../src/include/ $pg_language_dat $pg_proc_dat");
}
@@ -479,7 +478,6 @@ EOF
'src/backend/catalog/postgres.bki',
"src/include/catalog/$bki"))
{
print "Generating BKI files and symbol definition headers...\n";
chdir('src/backend/catalog');
my $bki_srcs = join(' ../../../src/include/catalog/', @bki_srcs);
system("perl genbki.pl --set-version=$self->{majorver} $bki_srcs");