1
0
mirror of https://github.com/postgres/postgres.git synced 2025-05-17 06:41:24 +03:00

Fix string_to_array() to correctly handle the case where there are

overlapping possible matches for the separator string, such as
string_to_array('123xx456xxx789', 'xx').
Also, revise the logic of replace(), split_part(), and string_to_array()
to avoid O(N^2) work from redundant searches and conversions to pg_wchar
format when there are N matches to the separator string.
Backpatched the full patch as far as 8.0.  7.4 also has the bug, but the
code has diverged a lot, so I just went for a quick-and-dirty fix of the
bug itself in that branch.
This commit is contained in:
Tom Lane 2006-10-07 00:12:12 +00:00
parent e0c6d9761c
commit 9cd5c4fca2

View File

@ -8,7 +8,7 @@
*
*
* IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/utils/adt/varlena.c,v 1.106.2.6 2006/05/21 20:06:43 tgl Exp $
* $Header: /cvsroot/pgsql/src/backend/utils/adt/varlena.c,v 1.106.2.7 2006/10/07 00:12:12 tgl Exp $
*
*-------------------------------------------------------------------------
*/
@ -779,6 +779,8 @@ text_position(Datum str, Datum search_str, int matchnum)
pos = p + 1;
break;
}
p1 += len2 - 1;
p += len2 - 1;
}
p1++;
}
@ -809,6 +811,8 @@ text_position(Datum str, Datum search_str, int matchnum)
pos = p + 1;
break;
}
p1 += len2 - 1;
p += len2 - 1;
}
p1++;
}