database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-07-28 23:42:10 +03:00
Code Activity

* When postgres.h does not define BYTE_ENDIAN pgcrypto

Browse Source 
produces garbage.

I learned the hard way that

        #if UNDEFINED_1 == UNDEFINED_2
        #error "gcc is idiot"
        #endif

prints "gcc is idiot" ...

Affected are MD5/SHA1 in internal library, and also HMAC-MD5/HMAC-SHA1/
crypt-md5 which use them.  Blowfish is ok, also Rijndael on at
least x86.

Big thanks to Daniel Holtzman who send me a build log which
contained warning:

        md5.c:246: warning: `X' defined but not used

Yes, gcc is that helpful...

Please apply this.

--
marko
This commit is contained in:
Bruce Momjian
2001-11-29 19:40:37 +00:00
parent 0556f7ca87
commit 8aa538cfd5
8 changed files with 21 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
contrib/pgcrypto/sha1.c
View File

@ -1,4 +1,4 @@
/* $Id: sha1.c,v 1.10 2001/11/05 17:46:23 momjian Exp $ */
/* $Id: sha1.c,v 1.11 2001/11/29 19:40:37 momjian Exp $ */
/* $KAME: sha1.c,v 1.3 2000/02/22 14:01:18 itojun Exp $ */
/*
@ -36,6 +36,7 @@
*/
#include "postgres.h"
#include "px.h"
#include "sha1.h"