database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-10-28 11:55:03 +03:00
Code Activity

* When postgres.h does not define BYTE_ENDIAN pgcrypto

Browse Source 
produces garbage.

I learned the hard way that

        #if UNDEFINED_1 == UNDEFINED_2
        #error "gcc is idiot"
        #endif

prints "gcc is idiot" ...

Affected are MD5/SHA1 in internal library, and also HMAC-MD5/HMAC-SHA1/
crypt-md5 which use them.  Blowfish is ok, also Rijndael on at
least x86.

Big thanks to Daniel Holtzman who send me a build log which
contained warning:

        md5.c:246: warning: `X' defined but not used

Yes, gcc is that helpful...

Please apply this.

--
marko
This commit is contained in:
Bruce Momjian
2001-11-29 19:40:37 +00:00
parent 0556f7ca87
commit 8aa538cfd5
8 changed files with 21 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
contrib/pgcrypto/crypt-blowfish.c
View File

@@ -32,7 +32,9 @@
#include "postgres.h"
#include "px.h"
#include "px-crypt.h"
#define __set_errno(v)
#ifndef __set_errno