database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2026-10-29 15:58:33 +03:00
Code Activity

Remove faulty Asserts added by 1999fe227.

Browse Source 
I added these assertions in an attempt to show that setting
ret_old_alias/ret_new_alias in set_deparse_plan() fully covered
all the parts of the plan where RETURNING Vars could be found.
But it emerges that the returningOldAlias/returningNewAlias
fields they are filled from can sometimes be NULL themselves,
allowing the asserts to fail.  We discussed various ways that
we might adjust the rewriter to prevent that, but the upshot
of the discussion was just to remove the asserts again.

Reported-by: Ayush Tiwari <ayushtiwari.slg01@gmail.com>
Author: Tom Lane <tgl@sss.pgh.pa.us>
Reviewed-by: Dean Rasheed <dean.a.rasheed@gmail.com>
Discussion: https://postgr.es/m/CAJTYsWWsORQbyViXmsvT4-NWkjuykkjjk2c+gQtq+vw2PJON-A@mail.gmail.com
Backpatch-through: 18
This commit is contained in:
Tom Lane
2026-10-23 10:29:45 -04:00
parent 1910daf983
commit 896246ea10
1 changed files with 0 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/backend/utils/adt/ruleutils.c
View File

@@ -7737,15 +7737,9 @@ get_variable(Var *var, int levelsup, bool istoplevel, deparse_context *context)
/* might be returning old/new column value */
if (var->varreturningtype == VAR_RETURNING_OLD)
{
refname = dpns->ret_old_alias;
Assert(refname);
}
else if (var->varreturningtype == VAR_RETURNING_NEW)
{
refname = dpns->ret_new_alias;
Assert(refname);
}
else
refname = (char *) list_nth(dpns->rtable_names, varno - 1);