database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2026-10-23 13:29:09 +03:00
Code Activity

Remove stale XXX comment in logical launcher

Browse Source 
An XXX comment in launcher.c added by commit 2af1dc8928 questioned why
the slot drop does not request disabling logical decoding.  But the
conflict detection slot is a physical slot, so there is no logical
decoding state to disable.  Remove that comment and clarify the
situation elsewhere.

Author: "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>
Reviewed-by: shveta malik <shveta.malik@gmail.com>
Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>
Backpatch-through: 19
Discussion: https://postgr.es/m/TY4PR01MB177186C8AB596F30DF704ECDC94B62@TY4PR01MB17718.jpnprd01.prod.outlook.com
This commit is contained in:
Álvaro Herrera
2026-09-09 11:10:15 +02:00
parent 86f7c82cf1
commit 7beefa8d46
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/backend/replication/logical/launcher.c
View File

@@ -1284,12 +1284,12 @@ ApplyLauncherMain(Datum main_arg)
retain_dead_tuples = true;
/*
* Create a replication slot to retain information necessary
* for conflict detection such as dead tuples, commit
* timestamps, and origins.
* Create a (physical) replication slot to retain information
* necessary for conflict detection such as dead tuples,
* commit timestamps, and origins.
*
* The slot is created before starting the apply worker to
* prevent it from unnecessarily maintaining its
* prevent the worker from unnecessarily maintaining its
* oldest_nonremovable_xid.
*
* The slot is created even for a disabled subscription to
@@ -1418,7 +1418,6 @@ ApplyLauncherMain(Datum main_arg)
if (MyReplicationSlot)
{
if (!retain_dead_tuples)
/* XXX unclear why we don't request logical decoding disable */
ReplicationSlotDropAcquired(false);
else if (can_update_xmin)
update_conflict_slot_xmin(xmin);
@@ -1627,6 +1626,11 @@ reset_conflict_slot_xmin_to_safe_horizon(void)
/*
* Create and acquire the replication slot used to retain information for
* conflict detection, if not yet.
*
* A physical slot is enough, as no logical decoding is going to be performed
* through it. In fact, the slot will only be used through its xmin horizon
* to prevent the removal of dead tuples and commit timestamp data required by
* subscriptions with retain_dead_tuples enabled in any database.
*/
void
CreateConflictDetectionSlot(void)