database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2026-01-26 09:41:40 +03:00
Code Activity

Fix issue with EVENT TRIGGERS and ALTER PUBLICATION

Browse Source 
When processing the "publish" options of an ALTER PUBLICATION command,
we call SplitIdentifierString() to split the options into a List of
strings.  Since SplitIdentifierString() modifies the delimiter
character and puts NULs in their place, this would overwrite the memory
of the AlterPublicationStmt.  Later in AlterPublicationOptions(), the
modified AlterPublicationStmt is copied for event triggers, which would
result in the event trigger only seeing the first "publish" option
rather than all options that were specified in the command.

To fix this, make a copy of the string before passing to
SplitIdentifierString().

Here we also adjust a similar case in the pgoutput plugin.  There's no
known issues caused by SplitIdentifierString() here, so this is being
done out of paranoia.

Thanks to Henson Choi for putting together an example case showing the
ALTER PUBLICATION issue.

Author: sunil s <sunilfeb26@gmail.com>
Reviewed-by: Henson Choi <assam258@gmail.com>
Reviewed-by: zengman <zengman@halodbtech.com>
Backpatch-through: 14
This commit is contained in:
David Rowley
2026-01-06 17:29:12 +13:00
parent 63ed3bc7f9
commit 6ca8506ea5
2 changed files with 11 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/backend/commands/publicationcmds.c
View File

@@ -121,7 +121,12 @@ parse_publication_options(ParseState *pstate,
pubactions->pubtruncate = false;
*publish_given = true;
publish = defGetString(defel);
/*
* SplitIdentifierString destructively modifies its input, so make
* a copy so we don't modify the memory of the executing statement
*/
publish = pstrdup(defGetString(defel));
if (!SplitIdentifierString(publish, ',', &publish_list))
ereport(ERROR,

6
src/backend/replication/pgoutput/pgoutput.c
View File

@@ -346,7 +346,11 @@ parse_output_parameters(List *options, PGOutputData *data)
errmsg("conflicting or redundant options")));
publication_names_given = true;
if (!SplitIdentifierString(strVal(defel->arg), ',',
/*
* Pass a copy of the DefElem->arg since SplitIdentifierString
* modifies its input.
*/
if (!SplitIdentifierString(pstrdup(strVal(defel->arg)), ',',
&data->publication_names))
ereport(ERROR,
(errcode(ERRCODE_INVALID_NAME),