database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2026-10-23 13:29:09 +03:00
Code Activity

test_saslprep: Fix issue with copy of input bytea

Browse Source 
The data given in input of the function may not be null-terminated,
causing strlcpy() to complain with an invalid read.

Issue spotted using valgrind.

Reported-by: Alexander Lakhin <exclusion@gmail.com>
Discussion: https://postgr.es/m/09df9d75-13e7-45fe-89af-33fe118e797b@gmail.com
This commit is contained in:
Michael Paquier
2026-04-13 09:06:17 +09:00
parent e3e26d04bd
commit 5d35531af1
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/test/modules/test_saslprep/test_saslprep.c
View File

@@ -84,7 +84,8 @@ test_saslprep(PG_FUNCTION_ARGS)
* Copy the input given, to make SASLprep() act on a sanitized string.
*/
input_data = palloc0(src_len + 1);
strlcpy(input_data, src, src_len + 1);
memcpy(input_data, src, src_len);
input_data[src_len] = '\0';
rc = pg_saslprep(input_data, &result);
status = saslprep_status_to_text(rc);