database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-06-13 07:41:39 +03:00
Code Activity

Fix planner's failure to identify multiple hashable ScalarArrayOpExprs

Browse Source 
50e17ad28 (v14) and 29f45e299 (v15) made it so the planner could identify
IN and NOT IN clauses which have Const lists as right-hand arguments and
when an appropriate hash function is available for the data types, mark
the ScalarArrayOpExpr as hashable so the executor could execute it more
optimally by building and probing a hash table during expression
evaluation.

These commits both worked correctly when there was only a single
ScalarArrayOpExpr in the given expression being processed by the
planner, but when there were multiple, only the first was checked and any
subsequent ones were not identified, which resulted in less optimal
expression evaluation during query execution for all but the first found
ScalarArrayOpExpr.

Backpatch to 14, where 50e17ad28 was introduced.

Author: David Geier <geidav.pg@gmail.com>
Discussion: https://postgr.es/m/29a76f51-97b0-4c07-87b7-ec8e3b5345c9@gmail.com
Backpatch-through: 14
This commit is contained in:
David Rowley
2025-04-02 11:57:54 +13:00
parent a39eb9c77f
commit 5a0840b767
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/backend/optimizer/util/clauses.c
View File

@ -2309,7 +2309,7 @@ convert_saop_to_hashed_saop_walker(Node *node, void *context)
/* Looks good. Fill in the hash functions */
saop->hashfuncid = lefthashfunc;
}
return true;
return false;
}
}
else /* !saop->useOr */
@ -2347,7 +2347,7 @@ convert_saop_to_hashed_saop_walker(Node *node, void *context)
*/
saop->negfuncid = get_opcode(negator);
}
return true;
return false;
}
}
}