mirror of
https://github.com/postgres/postgres.git
synced 2026-10-23 13:29:09 +03:00
Reject sequence synchronization against pre-PostgreSQL 19 publishers.
Sequence synchronization requires the page_lsn field returned by pg_get_sequence_data(), which was added in PostgreSQL 19. Previously, requesting sequence synchronization against an older publisher (via ALTER SUBSCRIPTION ... REFRESH SEQUENCES or by running ALTER SUBSCRIPTION ... CONNECTION on a disabled subscription with sequences in the INIT state and subsequently enabling the subscription) would cause the sequence synchronization worker to repeatedly fail with a confusing "invalid query response" error. Check the publisher's server version up front in both AlterSubscription_refresh_seq() and copy_sequences(), and error out immediately when it predates PostgreSQL 19. Also document the PostgreSQL 19 publisher requirement for sequence replication in the logical replication documentation and in ALTER SUBSCRIPTION ... REFRESH SEQUENCES. Reported-by: Noah Misch <noah@leadboat.com> Author: vignesh C <vignesh21@gmail.com> Reviewed-by: Shveta Malik <shveta.malik@gmail.com> Reviewed-by: Hayato Kuroda <kuroda.hayato@fujitsu.com> Reviewed-by: Amit Kapila <amit.kapila16@gmail.com> Backpatch-through: 19 Discussion: https://postgr.es/m/20260710045217.f0.noahmisch@microsoft.com
This commit is contained in:
@@ -1803,6 +1803,13 @@ Included in publications:
|
||||
configuration.
|
||||
</para>
|
||||
|
||||
<note>
|
||||
<para>
|
||||
Sequence synchronization requires the publisher to be running
|
||||
<productname>PostgreSQL</productname> 19 or later.
|
||||
</para>
|
||||
</note>
|
||||
|
||||
<sect2 id="sequence-definition-mismatches">
|
||||
<title>Sequence Definition Mismatches</title>
|
||||
<para>
|
||||
@@ -2353,7 +2360,16 @@ CONTEXT: processing remote data for replication origin "pg_16395" during "INSER
|
||||
<command>ALTER SUBSCRIPTION ... REFRESH SEQUENCES</command></link>
|
||||
or by copying the current data from the publisher (perhaps using
|
||||
<command>pg_dump</command>) or by determining a sufficiently high value
|
||||
from the tables themselves.
|
||||
from the tables themselves. Note that
|
||||
<link linkend="sql-altersubscription-params-refresh-sequences">
|
||||
<command>ALTER SUBSCRIPTION ... REFRESH SEQUENCES</command></link> only
|
||||
re-synchronizes sequences that are already known to the subscription
|
||||
(see <xref linkend="logical-replication-sequences"/>); in particular, it
|
||||
requires the publisher to be running <productname>PostgreSQL</productname>
|
||||
19 or later. Before relying on it to prepare for a switchover or
|
||||
failover, confirm that the publisher's version supports sequence
|
||||
replication and that the sequences of interest are already known to the
|
||||
subscription.
|
||||
</para>
|
||||
</listitem>
|
||||
|
||||
|
||||
@@ -245,6 +245,12 @@ ALTER SUBSCRIPTION <replaceable class="parameter">name</replaceable> RENAME TO <
|
||||
sequences are subscribed. Run <literal>REFRESH PUBLICATION</literal>
|
||||
first if the publication's set of sequences has changed.
|
||||
</para>
|
||||
<note>
|
||||
<para>
|
||||
Sequence replication requires the publisher to be running
|
||||
<productname>PostgreSQL</productname> 19 or later.
|
||||
</para>
|
||||
</note>
|
||||
<para>
|
||||
See <xref linkend="sequence-definition-mismatches"/> for
|
||||
recommendations on how to handle any warnings about sequence definition
|
||||
|
||||
@@ -1322,6 +1322,16 @@ AlterSubscription_refresh_seq(Subscription *sub)
|
||||
/* The publisher connection is only needed for the origin check. */
|
||||
PG_TRY();
|
||||
{
|
||||
/*
|
||||
* Sequence synchronization depends on publisher-side functionality
|
||||
* introduced in PostgreSQL 19, so it cannot work against an older
|
||||
* publisher.
|
||||
*/
|
||||
if (walrcv_server_version(wrconn) < 190000)
|
||||
ereport(ERROR,
|
||||
errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE),
|
||||
errmsg("cannot synchronize sequences if the publisher is running a version earlier than PostgreSQL 19"));
|
||||
|
||||
check_publications_origin_sequences(wrconn, sub->publications, true,
|
||||
sub->origin, NULL, 0, sub->name);
|
||||
}
|
||||
|
||||
@@ -444,6 +444,16 @@ copy_sequences(WalReceiverConn *conn)
|
||||
StringInfoData cmd;
|
||||
MemoryContext oldctx;
|
||||
|
||||
/*
|
||||
* Sequence synchronization depends on publisher-side functionality
|
||||
* introduced in PostgreSQL 19, so it cannot work against an older
|
||||
* publisher.
|
||||
*/
|
||||
if (walrcv_server_version(conn) < 190000)
|
||||
ereport(ERROR,
|
||||
errcode(ERRCODE_OBJECT_NOT_IN_PREREQUISITE_STATE),
|
||||
errmsg("cannot synchronize sequences if the publisher is running a version earlier than PostgreSQL 19"));
|
||||
|
||||
initStringInfo(&seqstr);
|
||||
initStringInfo(&cmd);
|
||||
|
||||
|
||||
Reference in New Issue
Block a user