database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2026-01-26 09:41:40 +03:00
Code Activity

Fix possible incorrect column reference in ERROR message

Browse Source 
When creating a partition for a RANGE partitioned table, the reporting
of errors relating to converting the specified range values into
constant values for the partition key's type could display the name of a
previous partition key column when an earlier range was specified as
MINVALUE or MAXVALUE.

This was caused by the code not correctly incrementing the index that
tracks which partition key the foreach loop was working on after
processing MINVALUE/MAXVALUE ranges.

Fix by using foreach_current_index() to ensure the index variable is
always set to the List element being worked on.

Author: myzhen <zhenmingyang@yeah.net>
Reviewed-by: zhibin wang <killerwzb@gmail.com>
Discussion: https://postgr.es/m/273cab52.978.19b96fc75e7.Coremail.zhenmingyang@yeah.net
Backpatch-through: 14
This commit is contained in:
David Rowley
2026-01-09 11:01:36 +13:00
parent b8ccd29152
commit 349107537d
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/backend/parser/parse_utilcmd.c
View File

@@ -4758,12 +4758,14 @@ transformPartitionRangeBounds(ParseState *pstate, List *blist,
int i,
j;
i = j = 0;
j = 0;
foreach(lc, blist)
{
Node *expr = lfirst(lc);
PartitionRangeDatum *prd = NULL;
i = foreach_current_index(lc);
/*
* Infinite range bounds -- "minvalue" and "maxvalue" -- get passed in
* as ColumnRefs.
@@ -4841,7 +4843,6 @@ transformPartitionRangeBounds(ParseState *pstate, List *blist,
prd = makeNode(PartitionRangeDatum);
prd->kind = PARTITION_RANGE_DATUM_VALUE;
prd->value = (Node *) value;
++i;
}
prd->location = exprLocation(expr);