database/postgres
1
0
Fork 0
mirror of https://github.com/postgres/postgres.git synced 2025-08-09 17:03:00 +03:00
Code Activity

Ignore PQcancel errors properly

Browse Source 
Add a (void) cast to all PQcancel() calls that purposefully don't check
the return value, to keep compilers and static checkers happy.

Per Coverity.
This commit is contained in:
Alvaro Herrera
2017-05-09 14:58:51 -03:00
parent 57811b751a
commit 345bf97b80
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/bin/pg_dump/pg_backup_db.c
View File

@@ -342,12 +342,12 @@ DisconnectDatabase(Archive *AHX)
if (AH->connCancel)
{
/*
* If we have an active query, send a cancel before closing. This is
* of no use for a normal exit, but might be helpful during
* exit_horribly().
* If we have an active query, send a cancel before closing, ignoring
* any errors. This is of no use for a normal exit, but might be
* helpful during exit_horribly().
*/
if (PQtransactionStatus(AH->connection) == PQTRANS_ACTIVE)
PQcancel(AH->connCancel, errbuf, sizeof(errbuf));
(void) PQcancel(AH->connCancel, errbuf, sizeof(errbuf));
/*
* Prevent signal handler from sending a cancel after this.